Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(world): workaround resolve json issue #3022

Closed
wants to merge 2 commits into from

Conversation

holic
Copy link
Member

@holic holic commented Aug 9, 2024

can either turn on resolveJsonModule but get weaker types or turn it off and get strong types from our generated .json.d.ts, but not both

this attempts to work around this issue by manually importing the ABI types we need when we need them 😭

can either turn on resolveJsonModules but get weaker types or turn it off and get strong types from our generated .json.d.ts, but not both

this attempts to work around this issue
Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 50a242f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic
Copy link
Member Author

holic commented Aug 9, 2024

this was a workaround for issues in #3001 when extending the workspace root tsconfig, but we decided we'll just let explorer have its own tsconfig (since its never imported as a package, only used as a binary/service)

@holic holic closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant