-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli,world): register system ABI onchain #3050
Conversation
🦋 Changeset detectedLatest commit: 5ebb331 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
okay so after two attempts, I understand this a bit better we currently have a constraint/order of operations
I tried to simplify by just
but we lean on just ABI for a number of reasons:
so then I went the other way
but that is also fraught because just parsing solidity skips parts of the compiler we need, like resolving imports with remappings, resolving underlying types of enums/user types, converting structs to tuples so we can't actually create pure/true representation of the ABI and reimplementing all that in the "parse solidity" step seems like a bad idea all this to figure out where the right "entry point" is for generating the local system manifest and I think it's in to recap:
there's still the problem of the ABI not including enough data for a 1:1 interface (e.g. |
1335761
to
f6bd603
Compare
76572cd
to
d87d44c
Compare
d87d44c
to
a0980a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
.mud
to.gitignore
in templates, etc.namespaceLabel
to config's system output