Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(world/modules): add mud.config.ts installation 🚗 #3052

Merged
merged 7 commits into from
Aug 30, 2024
Merged

docs(world/modules): add mud.config.ts installation 🚗 #3052

merged 7 commits into from
Aug 30, 2024

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Aug 20, 2024

Closing: #3051

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 09e2275

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@qbzzt qbzzt changed the title doc(world/modules): add mud.config.ts installation doc(world/modules): add mud.config.ts installation 🚗 Aug 20, 2024
@qbzzt qbzzt changed the title doc(world/modules): add mud.config.ts installation 🚗 docs(world/modules): add mud.config.ts installation 🚗 Aug 20, 2024
holic
holic reviewed Aug 21, 2024
View reviewed changes
docs/pages/world/modules.mdx Outdated Show resolved Hide resolved
holic
holic reviewed Aug 21, 2024
View reviewed changes
docs/pages/world/modules.mdx Outdated Show resolved Hide resolved
@qbzzt qbzzt requested a review from holic August 22, 2024 00:33
holic
holic reviewed Aug 27, 2024
View reviewed changes
docs/pages/config/reference.mdx
- **type** - Solidity data type.
- **value** - the value.
To encode a complex data type, such as a structure or an array, you can use Viem's [`encodeAbiParameters`](https://viem.sh/docs/abi/encodeAbiParameters.html).
</Param>
Copy link
Member

@holic holic Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use embedded params rather than a list? see system deploy section as an example

image

rather than

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that first. But it doesn't give enough space for the text at the third level of nesting, IMAO.

Screenshot 2024-08-27 at 9 55 07 AM

holic
holic reviewed Aug 27, 2024
View reviewed changes
docs/pages/world/modules.mdx Outdated Show resolved Hide resolved
@qbzzt qbzzt requested a review from holic August 27, 2024 15:47
@holic
Copy link
Member

holic commented Aug 30, 2024

line numbers look off now:
image

@qbzzt
Copy link
Contributor Author

qbzzt commented Aug 30, 2024

Ugh, prettier. OK, fixed now.

@holic holic merged commit a907be8 into main Aug 30, 2024
5 checks passed
@holic holic deleted the 240820-mod-installation branch August 30, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludns ludns Awaiting requested review from ludns ludns is a code owner

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

@holic holic Awaiting requested review from holic holic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbzzt @holic