fix(common): use pending block tag in tx queue #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 97cb87e The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
holic
commented
Aug 27, 2024
| debug("sending tx to", request.to, "with nonce", nonce); | ||
| return await getAction(client, viem_sendTransaction, "sendTransaction")(params); | ||
| return await getAction(client, viem_sendTransaction, "sendTransaction")(params as never); |
There was a problem hiding this comment.
viem types don't like blockTag here, but it does make it through to the eth_estimateGas RPC call, so I'm hoping to get this fixed upstream
holic
commented
Aug 27, 2024
| >( | ||
| client: Client<Transport, chain, account>, | ||
| request: SendTransactionParameters<chain, account, chainOverride>, | ||
| request: SendTransactionParameters<chain, account, chainOverride, request>, |
There was a problem hiding this comment.
these changes align with viem's type signature (forgot to do this last version bump)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we refactored these actions in #3043, but missed that
estimateGasis not called withpendingblock tag by default (but was what we used before)