Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): write observer #3169

Merged
merged 6 commits into from
Sep 12, 2024
Merged

feat(explorer): write observer #3169

merged 6 commits into from
Sep 12, 2024

Conversation

holic
Copy link
Member

@holic holic commented Sep 11, 2024

image

(visuals of "Observe" tab are a WIP)

this nearly brings us to almost complete dev tools parity 🎉

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 7ef3daf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/explorer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch
ts-benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

karooolis
karooolis previously approved these changes Sep 12, 2024
Copy link
Contributor

@karooolis karooolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the path has changed, some links don't work anymore. Noticed in error.tsx, not-found.tsx, and worlds/[worldAddress]/page.tsx.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed!

packages/explorer/src/observer/bridge.ts Outdated Show resolved Hide resolved
packages/explorer/src/observer/relay.ts Show resolved Hide resolved
@holic holic merged commit 784e5a9 into main Sep 12, 2024
12 checks passed
@holic holic deleted the holic/explorer-observe branch September 12, 2024 14:55
@holic holic mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants