fix(explorer): various fixes #3195
Conversation
🦋 Changeset detectedLatest commit: 0779301 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
There was a problem hiding this comment.
See it has been changed back to icon.svg. Would be nice to use layout's metadata but can't figure out quickly how to make that work from a non-root path so I'm fine with it, especially since it meets next.js convention.
There was a problem hiding this comment.
yeah I couldn't figure out why specifying the path in page meta lead to a bunch of invalid requests to the icon, even though the meta tag rendered fine and had the correct path
changing this to just icon.svg follows the next.js convention which serves the icon automatically: https://nextjs.org/docs/app/api-reference/file-conventions/metadata/app-icons#image-files-ico-jpg-png
| export const supportedChainsById = Object.fromEntries( | ||
| Object.entries(supportedChains).map(([, chain]) => [chain.id, chain]), | ||
| ); | ||
| export type supportedChains = typeof supportedChains; |
There was a problem hiding this comment.
Wonder if it should start uppercase given it's a type, and that's been the convention so far? Same for supportedChainName and supportedChainId
There was a problem hiding this comment.
this is just a shortcut to avoid having to sprinkle typeof everywhere you're using it with a const
when the name mirrors the type, you can use the same name/reference in both types and runtime (we borrowed this pattern from arktype and use it throughout config etc.)
observer()options arg optional