feat: Parametrize iana database download_url #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rai200890
force-pushed
the
feat/iana-download-url
branch
2 times, most recently
from
cc1dbb3 to
d183840
Compare
rai200890
changed the title
rai200890
force-pushed
the
feat/iana-download-url
branch
from
d183840 to
c408acd
Compare
rai200890
force-pushed
the
feat/iana-download-url
branch
from
c408acd to
c67ce94
Compare
yashin5
approved these changes
Sep 6, 2024
ramondelemos
reviewed
Sep 6, 2024
rai200890
force-pushed
the
feat/iana-download-url
branch
from
8309d4b to
66f4786
Compare
ramondelemos
approved these changes
Sep 6, 2024
|
I think this new config should also be explained in the README so its discoverable in the documentation |
rai200890
force-pushed
the
feat/iana-download-url
branch
from
66f4786 to
68cfb34
Compare
Co-authored-by: Brandyn Bennett <[email protected]>
rai200890
force-pushed
the
feat/iana-download-url
branch
from
68cfb34 to
0fee5cd
Compare
lucassgomes
approved these changes
Sep 6, 2024
gfviegas
approved these changes
Sep 6, 2024
|
thanks. locking down to a specific version is a great idea |
jsvitolo
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make IANA timezone database download url overridable.
Closes #143
On application config: