Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure blocking read stream can be shutdown #37

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: Ensure blocking read stream can be shutdown #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ld_eventsource/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,15 @@ def connect(self, last_event_id: Optional[str]) -> Tuple[Iterator[bytes], Callab
raise HTTPContentTypeError(content_type or '')

stream = resp.stream(_CHUNK_SIZE)
return stream, resp.release_conn

def close():
try:
resp.shutdown()
except AttributeError:
pass
resp.release_conn()

return stream, close

def close(self):
if self.__should_close_pool:
Expand Down
Loading