Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Docile https://github.com/ms-ati/docile instead of cooking our own DSL building logic would have some benefits:
pena
already has docile as some of its gems dependencies.piperator
to maintain asBuilder
now significantly simplified@counter
can not really be usedOn the other hand it's an extra dependency to a small utility library which so far has had none. I can certainly see the appeal in keeping things that way. Also the instance variable handling has raised some concerns ms-ati/docile#37