Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the issue with the network idle timeout #614

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Resolve the issue with the network idle timeout #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1647478
🐛 fix(playwright): correct timeout unit from sec to ms
agn-7 Oct 9, 2024
fbc3380
🔨 use TimeoutError exception explicitly
agn-7 Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions lavague-integrations/drivers/lavague-drivers-playwright/lavague/drivers/playwright/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from PIL import Image
from typing import Callable, Optional, Any, Mapping, Dict, List
from lavague.core.utilities.format_utils import extract_code_from_funct
from playwright.sync_api import Page, Locator
from playwright.sync_api import Page, Locator, TimeoutError
from lavague.core.base_driver import (
BaseDriver,
JS_GET_INTERACTIVES,
Expand All @@ -30,8 +30,8 @@ def __init__(
width: int = 1080,
height: int = 1080,
user_data_dir: Optional[str] = None,
log_waiting_time=False,
waiting_completion_timeout=10,
log_waiting_time: bool = False,
waiting_completion_timeout: int = 10, # seconds
):
os.environ["PW_TEST_SCREENSHOT_NO_FONTS_READY"] = (
"1" # Allow playwright to take a screenshots even if the fonts won't load in head mode.
Expand Down Expand Up @@ -284,10 +284,9 @@ def wait_for_idle(self):
t = time.time()
try:
self.page.wait_for_load_state(
"networkidle", timeout=self.waiting_completion_timeout
"networkidle", timeout=self.waiting_completion_timeout * 1000
)
except:
# timeout occurred
except TimeoutError:
pass
elapsed = time.time() - t
self.wait_for_dom_stable(self.waiting_completion_timeout - elapsed)
Expand Down Expand Up @@ -380,7 +379,7 @@ def get_capability(self) -> str:
<tab class="devsite-active" xpath="/html/body/section/devsite-header/div/div[1]/div/div/div[2]/div[1]/devsite-tabs/nav/tab[1]">
<a aria-label="Gemini API, selected" class="devsite-tabs-content gc-analytics-event" data-category="Site-Wide Custom Events" data-label="Tab: Gemini API" href="https://ai.google.dev/gemini-api" track-metadata-eventdetail="https://ai.google.dev/gemini-api" track-metadata-module="primary nav" track-metadata-position="nav - gemini api" track-name="gemini api" track-type="nav" xpath="/html/body/section/devsite-header/div/div[1]/div/div/div[2]/div[1]/devsite-tabs/nav/tab[1]/a">
Gemini API

</a>
</tab>
<tab class="devsite-overflow-tab" xpath="/html/body/section/devsite-header/div/div[1]/div/div/div[2]/div[1]/devsite-tabs/nav/tab[2]"><!-- -->
Expand All @@ -389,12 +388,12 @@ def get_capability(self) -> str:
<tab xpath="/html/body/section/devsite-header/div/div[1]/div/div/div[2]/div[1]/devsite-tabs/nav/tab[2]/div/tab[1]">
<a class="devsite-tabs-content gc-analytics-event" data-category="Site-Wide Custom Events" data-label="Tab: Gemma" href="https://ai.google.dev/gemma" track-metadata-eventdetail="https://ai.google.dev/gemma" track-metadata-module="primary nav" track-metadata-position="nav - gemma" track-name="gemma" track-type="nav" xpath="/html/body/section/devsite-header/div/div[1]/div/div/div[2]/div[1]/devsite-tabs/nav/tab[2]/div/tab[1]/a">
Gemma

</a>
</tab><tab xpath="/html/body/section/devsite-header/div/div[1]/div/div/div[2]/div[1]/devsite-tabs/nav/tab[2]/div/tab[2]">
<a class="devsite-tabs-content gc-analytics-event" data-category="Site-Wide Custom Events" data-label="Tab: Google AI Edge" href="https://ai.google.dev/edge" track-metadata-eventdetail="https://ai.google.dev/edge" track-metadata-module="primary nav" track-metadata-position="nav - google ai edge" track-name="google ai edge" track-type="nav" xpath="/html/body/section/devsite-header/div/div[1]/div/div/div[2]/div[1]/devsite-tabs/nav/tab[2]/div/tab[2]/a">
Google AI Edge


Query: Click on "Gemma" under the "More" dropdown menu.
Completion:
Expand Down