refactor: CNS-1008 - Optimizer Refactor Part 1: provider optimizer refactor

[oren-lava]

Description

Closes: #XXXX

I refactored the provider optimizer and fixed various bugs it had. I did the refactor in files with "_refator" suffix to be able to test the new optimizer while not hurting the current one

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• read the contribution guide
• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the main branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[github-actions]

Test Results

2 492 tests  +69   2 492 ✅ +70   26m 21s ⏱️ + 6m 54s
  122 suites ± 0       0 💤 ± 0 
    7 files   ± 0       0 ❌  -  1 

Results for commit 562bb29. ± Comparison against base commit 8943739.

This pull request removes 14 and adds 83 tests. Note that renamed tests count towards both.

github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestPerturbationWithNormalGaussianOnConcurrentComputation
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProbabilitiesCalculations
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProbabilitiesCalculations/almost_there
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProbabilitiesCalculations/five
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProbabilitiesCalculations/one
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProbabilitiesCalculations/tight
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerAvailability
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerBasic
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerSetGet
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerWithOptimizerQoSClient
…

github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerAvailabilityProbeData
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerBasicProbeData
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerChoiceSimulation
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerChooseProvider
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerLatencySyncScore
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerProviderDataSetGet
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerRetriesWithReducedProvidersSet
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestProviderOptimizerUpdatingLatency
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestSelectionTierInstGetTierBig/tier_1,_25_entries
github.com/lavanet/lava/v4/protocol/provideroptimizer ‑ TestSelectionTierInstGetTierBig/tier_2,_25_entries
…

♻️ This comment has been updated with latest results.

[omerlavanet]

this code is a piece of art, taking something so complex and making it so clear

[ranlavanet]

Very nice job!

No longer relvant