Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CustomTooltip component to the sistent components page #6058

Merged
merged 9 commits into from
Nov 24, 2024
Merged

Add CustomTooltip component to the sistent components page #6058

merged 9 commits into from
Nov 24, 2024

Conversation

Vidit-Kushwaha
Copy link
Contributor

Description

Add CustomTooltip component to the sistent components page

  • Added explanation of the function CustomTooltip component and it's usage.
  • Code examples.
  • Stylistic guidelines to be followed.

This PR fixes #5890

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

image

@github-actions github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Nov 4, 2024
@l5io
Copy link
Contributor

l5io commented Nov 4, 2024

🚀 Preview for commit ca6e47a at: https://6728980406bc4571c4f1e14d--layer5.netlify.app

@vishalvivekm
Copy link
Member

@Vidit-Kushwaha Let's discuss this on websites call on Monday at 6:30 PM IST (7:00 AM CT). I have added this as an agenda item to the meeting minutes.

@Vidit-Kushwaha Vidit-Kushwaha marked this pull request as draft November 7, 2024 13:50
@Vidit-Kushwaha
Change customTooltip to tooltip, remove sistentheme layer from code, …
85639ce 
…added triggers, html support in guidance.js

Signed-off-by: Vidit Kushwaha <[email protected]>
@Vidit-Kushwaha
Merge branch 'master' into add/customTooltip
db8ddac 
Signed-off-by: Vidit Kushwaha <[email protected]>
@Vidit-Kushwaha Vidit-Kushwaha marked this pull request as ready for review November 11, 2024 04:57
@l5io
Copy link
Contributor

l5io commented Nov 11, 2024

🚀 Preview for commit db8ddac at: https://673191407fd1e3a32746b922--layer5.netlify.app

@Vidit-Kushwaha
added markdown support
9e32414 
Signed-off-by: Vidit Kushwaha <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 12, 2024

🚀 Preview for commit 9e32414 at: https://67333040eb4a8b0c6bc658b9--layer5.netlify.app

@Vidit-Kushwaha
rename title of tooltip
44e6eff 
Signed-off-by: Vidit Kushwaha <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 12, 2024

🚀 Preview for commit 44e6eff at: https://673337ef3a86680946bbe083--layer5.netlify.app

@sudhanshutech
Copy link
Member

@Vidit-Kushwaha merge conflict

@Vidit-Kushwaha
Copy link
Contributor Author

Vidit-Kushwaha commented Nov 15, 2024 •
edited
Loading

@sudhanshutech Resolved merge conflicts

@l5io
Copy link
Contributor

l5io commented Nov 15, 2024

🚀 Preview for commit 119854b at: https://6736cd1860d06fe4d2350e33--layer5.netlify.app

@sudhanshutech
Copy link
Member

@Vidit-Kushwaha please update to new structure that you made that is we do not require dir inside pages.

@l5io
Copy link
Contributor

l5io commented Nov 24, 2024

🚀 Preview for commit 3d6ce99 at: https://6742fce5a50f03719738990c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 24, 2024

🚀 Preview for commit 3bcaf46 at: https://67430654e47b0b6f06fcc5cb--layer5.netlify.app

@sudhanshutech sudhanshutech merged commit 947ec3d into layer5io:master Nov 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/projects An issue relating to Layer5 initiatives (projects) area/site-config project/sistent
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sistent] Add CustomTooltip component to the sistent components page
4 participants
@Vidit-Kushwaha @l5io @vishalvivekm @sudhanshutech