test(components): add data-test-ids for e2e tests #870
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: THEBOSS0369 <anujkumsharma9876@gmail.com>
|
Thank you for your contribution @THEBOSS0369 Add it as an agenda item to the meeting minutes, if you would. |
|
Done @SAHU-01 |
|
There is no requirement of passing test-id like this. without doing this we can also pass the test-id. |
Okay cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #869
Data Test IDs has been added in components Typography, Button and Input
This PR is created because there weren't Test ids in components which we are using in E2E Tests
This is the PR link where we need these Data Test Ids
Signed commits