-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
h #12
Open
Yannik101010
wants to merge
145
commits into
lbechberger:main
Choose a base branch
from
dhesenkamp:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
h #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge classifier branch
Implemented a tokenizer in tokenizer.py by hand as seen in the lecture. Modified all corresponding files involved in the preprocessing.
Updated order (tokenize BEFORE export)
Created documentation file with basic structure. More to be added
Tokenizer
Added option to supply input column
Modified punctuation_remover.py
Resolving merge conflict manually by deleting affected files, then re-creating them by pulling from upstream
Implemented stopword remover based on nltk.corpus.stopwords. Needs further refining, currently raises KeyError
Changed method of iterating over the input column. Still doesn't work, no words removed
Still not working, but raises no error. Problem with properly accessing the column?
Still doesn't work, problem with literal_eval()? Code works as supposed in jupyter though
Comment, imports
Stop word removal
Implemented a lemmatizer based on nltk.stem.WordNetLemmatizer()
Edited corresponding files, added Lemmatizer() to script, added command line args and suffix
Cleaner code, added downloader for spaCy's language model to script. Tested pipeline.
This reverts commit 5df0545.
NER feature extraction
Added both classifier & command line args. Testing successful. Minor changes to documentation
Added MLP classifier
+ added parameter logging for the classifier
The Bayes classifier can't work with negative values, hence the moved scale for the sentiment analysis. Added note to documentation.
Complement NB classifier
Added more comments and cleaned up code.
Added all of our new parameters to the README.md
Runs all configurations
Include all param configurations and document search for optimal parameters
Parameter optimization and documentation
Documentation + visuals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h