exclude mos from file #160
Conversation
whitespace for pep8
| @@ -0,0 +1,7 @@ | |||
| # skip some mos tests | |||
There was a problem hiding this comment.
What is this file doing? I don't see it anywhere else used in the code.
There was a problem hiding this comment.
I used it locally to test whether the new function works, will write a proper test instead and use it there.
| counter += 1 | ||
| return counter | ||
|
|
||
| def setExcludeMosFromFile(self, excludeFile=None): |
There was a problem hiding this comment.
I don't understand why you allow excludeFile=None in which case the function does nothing. I don't think users will call a function to exclude files, and expect the function to do nothing?
Also, this function is not used in test_development_regressiontest.py. Please add so it becomes part of the testing.
There was a problem hiding this comment.
I am not sure I undestand the first comment. Should I just remove the None? The function can currently only add things to the list, should it be renamed?
| else: | ||
| print("*** Warning: Excluded file {} from the regression tests.".format(fileName)) | ||
| if filNam in self._excludeMos: | ||
| print("*** Warning: Excluded file {} from the regression tests.".format(filNam)) |
There was a problem hiding this comment.
Use self._reporter.writeWarning rather than write to console, otherwise the console and unitTest.log will show different things.
There was a problem hiding this comment.
That line was just copied, I will change it to write to the log file.
use self._reporter.writeWarning
using skpFil = skipUnitTestList.txt
|
All comments addressed |
|
@thorade I changed the following:
I will merge when the tests pass. |
This adds a new function that can populate the global _excludeMos list from a file.
This closes #143.