Bump setuptools from 46.0.0 to 65.5.1 #63
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [setuptools](https://github.com/pypa/setuptools) from 46.0.0 to 65.5.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v46.0.0...v65.5.1) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
@JayHuLBL : can you please process this PR to apply this security patch. See the failed test, please make sure they pass (or drop python 2.7 if no longer needed). Once fixed in |
|
With gcc version 9.x, the command |
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
setup.py
Outdated
| @@ -31,15 +31,14 @@ | |||
| long_description=README, | |||
| long_description_content_type='text/markdown', | |||
| license="3-clause BSD", | |||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*', | |||
| python_requires='>2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*', | |||
There was a problem hiding this comment.
In CMake (https://github.com/lbl-srg/funnel/pull/63/files#diff-cdd48abbd3eb8d1c54077449fc74a8de1f29805d2be5d8e5232b7aab76ea7a6fL16) and in requirements.txt Python 2.7 is no longer supported. Why is >2.7 here if the 2.x series is not tested?
src/readCSV.c
Outdated
| fgets(buf,100,fp); // skip the first "skipLines" lines | ||
| // skip the first "skipLines" lines | ||
| if (fgets(buf,100,fp) == NULL){ | ||
| exit(1); |
There was a problem hiding this comment.
How is the error that leads to a non-zero exit code reported to the user? It looks like line 82 is true if the EOF is encountered or an error is encountered. This must be reported to stderr, no? If not, how would a user understand why the program exits with an error?
|
Regarding #63 (comment), if we drop Python 2.7, then this is not backward compatible and hence we need to update the version to 4.0.0. See https://semver.org/ |
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
|
@mwetter I think this PR is ready to merge. Then should we release the tool as version 1.0.0, as the change drops Python 2.x? And then add the release new version number in |
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
…/lbl-srg/funnel into dependabot/pip/setuptools-65.5.1
|
The PR can be merged as the |
Bumps setuptools from 46.0.0 to 65.5.1.
Release notes
Sourced from setuptools's releases.
... (truncated)
Changelog
Sourced from setuptools's changelog.
... (truncated)
Commits
a462cb5Bump version: 65.5.0 → 65.5.1de35d8bMerge pull request #3656 from bmorris3/typos58e23deUpdate changelog. Ref #3659.43a9c9bLimit the amount of whitespace to search/backtrack. Fixes #3659.5791343Add test capturing failed expectation. Ref #3659.1f97905⚫ Fade to black.6254567Remove workaround for emacs.729b180⚫ Fade to black.c068081Typo correctionsf777a40Suppress deprecation warning in --rsyncdir. Workaround for #3655.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.