Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue203 logical expression #204

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

JayHuLBL
Copy link
Contributor

This closes #203.

By running the npx standard, we will still see the warning:

jianjunhu@ubuntu:~/GitFolder/modelica-json$ npx standard
standard: Use JavaScript Standard Style (https://standardjs.com)
  /home/jianjunhu/GitFolder/modelica-json/test/test_jsonquery.js:21:5: Invalid loop. Its body allows only one iteration. (no-unreachable-loop)
  /home/jianjunhu/GitFolder/modelica-json/test/test_parser.js:54:25: Array.prototype.map() expects a return value from arrow function. (array-callback-return)

This would need to be addressed in separated issue.

@JayHuLBL JayHuLBL requested a review from anandkp92 January 24, 2023 22:10
@JayHuLBL JayHuLBL self-assigned this Jan 24, 2023
@anandkp92
Copy link
Member

@JayHuLBL Can you also make changes to the json2mo folder for logical_expression and simple_expression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parsing logical expression
2 participants