-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LMB-1232 | Manage a concept-scheme with their concepts #1
base: master
Are you sure you want to change the base?
Conversation
…ementations and concepts
controller/concept-scheme.ts
Outdated
PREFIX skos: <http://www.w3.org/2004/02/skos/core#> | ||
PREFIX mu: <http://mu.semte.ch/vocabularies/core/> | ||
|
||
SELECT DISTINCT ?concept ?implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you only seem to be interested in whether an implementation exists, this query is inefficient and will return duplicate concepts if the concept is used multiple times.
You should do an aggregate query with a sample() function
router/concept-scheme.ts
Outdated
const conceptUris = (await getConceptsInConceptScheme(conceptSchemeUri)).map( | ||
(concept) => concept.uri, | ||
); | ||
await deleteConceptsWithImplementations(conceptUris); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your query will become quite large if there are e.g. 1000s of values in the concept scheme (unlikely but not impossible for our usecase)
better to have a query that deletes the concepts without specifying their values
… delete for concept route /batch
Description
We want this service to manage concept-schemes with their concepts.
How to test
Links to other PR's
Debug compose