Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4552: update ember to 4.12.x #116

Merged
merged 5 commits into from
Nov 2, 2023
Merged

GN-4552: update ember to 4.12.x #116

merged 5 commits into from
Nov 2, 2023

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Oct 30, 2023

Overview

This PR includes the following changes:

connected issues and PRs:

GN-4552

How to test/reproduce

  • Start the application
  • Check if you find any breaking issues (especially with regard to ember-data)

Challenges/uncertainties

This PR only includes minor updates of packages, there should not be any new issues.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma force-pushed the internal/ember-4.12 branch from 2f6f666 to fa7a961 Compare October 30, 2023 09:16
@abeforgit abeforgit merged commit abb2ea8 into master Nov 2, 2023
@abeforgit abeforgit deleted the internal/ember-4.12 branch November 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants