-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humble Launch Improvements #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_stack into dev-humble-launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #176
This PR targets
2.0.0
. This will likely be the last majorhumble
release and should pave the way for ROS index binaries. Following PRs will aim atrolling
.Contributors
Related PRs
Issues Tracker
1.5.0
)Desired Changes
Add(would require source, which renders it redundant)${ROS_DISTRO}
to install instructionIntroduce node composition in launch filesto be done laterBlockers:
ros2_control
via composition: ros2_control_node via composition ros-controls/ros2_control#1261rviz2
via composition: rviz2 via composition ros2/rviz#1114ros2_control_node
: Read robot description from robot state publisherUse an event handler for robot state publisherLoadingrobot_description
from topic does not work as expected ros-controls/ros2_control#1262lbr_fri_msgs
lbr_fri_ros2
interface testslbr_bringup
, or intolaunch_mixins
, see https://github.com/mhubii/demo_launchworld
->lbr/world
app.launch.py
from demos in favor forros2_control
variant (v1.4.x
ros2_control
in readmegazebo_ros2_control
package inlbr.gazebo.xacro
lbr_fri_msgs
->lbr_fri_idl
LBRPositionCommand
->LBRJointPositionCommand
https://x.com/jdorfman/status/1655582823082782721?s=20