[will be dropped]From my own purpose. #32

Robert-Ordis · 2022-03-07T15:39:22Z

All of these changes are came from my purpose (making real-time rewindable plotter app.).

Able to seek/rewind timeline.
Able to remove Serie from Chart.
Avoid to be affected by NTP
Able to push arbitrary ordered timeline data.

If you are interested in these code or thought you can make these code better,
then take a light look please.

…(for my own use)

…om widget. -> Caused by circular reference between Chart and Series.

…ommended)

…me(). -> To avoid warping time-diff by NTP.

- To reduce draw call by limiting the range efficiently(?) with using RBST. - I encountered a problem by pushing values with random timepoint on List.

Robert-Ordis · 2022-03-07T15:41:34Z

sorry i forgot to commit "changed" test code.
I'll push them later.

->pushed

lcallarec · 2022-03-07T19:54:58Z

Whooo, very interesting ! Thanks for sharing, I'll take a deeper look in the next weeks, but I like what you've done.

Robert-Ordis · 2022-03-08T05:00:18Z

Thank you for replying.
Because of prefering to implement earlier, there are various dirty code probably.
So, please show me the better approach if you find.(especially, Config.TimeSeek, Config.width...)

Robert-Ordis · 2022-11-29T05:17:10Z

Can I submit more pull requests ?
I tried to add more abilities for my own purpose.

Showing reticle and actual value from specified position(x, y)
Handling mouse event: to scroll and click legend area to detect the legend that user want to do something.
Handling mouse event: pointing a plot area to manipulate a reticle.
fix: 0 < y < 1 at first will make app crush (at least my environment)
Showing minus value.
and some tweaks.

But more abilities are implemented on the original repository after this pull request.
So, I don't understand if I can push these modifications.

taozuhong · 2022-11-29T08:13:02Z

meson.build

 vala_args = ['--target-glib=2.50']

+#setting up gtk
+gtk_major = 3


GTK version should define in meson_options.txt:

option('GTK', type: 'integer', value: 4, description : 'GTK version')

then use it in the meson:

if 3 == get_option('GTK') else endif

then change the GTK version by command:
meson -DGTK=3 build

Thank you.
I tried it, and it works.
I'll take it in my repository later.

By the way, as talked in #37, the default build should be GTK3 for now if we don't provide any argument to meson.

taozuhong · 2022-11-29T08:48:35Z

Do you mind that your repo behind upstream 20 commits?

you should rebase to upstream immediately.

Robert-Ordis · 2022-11-29T09:16:56Z

Yes, I know.
I'm wondering if my pull request will be accepted or rejected, ... or just ignored or forgotten.
(I knew Mr.Callarec's newer commiting recently.)

Rebasing is my job for now.
But on the other hand, I'm thinking that if my PR would be left alone, then I have to work for my version as the branched version.

From the very start, my modification is for my own project which named "omni-plotter".

stsdc · 2022-11-29T12:59:05Z

hey, @lcallarec can you look into this PR? Would be cool to have these features 😄

Robert-Ordis · 2022-11-29T13:11:52Z

@stsdc Thank you for your comment.
Did you see my code?
2nd of my additional features(Mainly, about the reticle) are not in "master" branch in my repository.

taozuhong · 2022-11-29T13:18:38Z

Do you mind rebasing my PR #37? it's done for GTK4 now, all examples work fine.

Robert-Ordis · 2022-11-29T13:27:19Z

@taozuhong
Thx. I'll find my time to do it.
I also tried to performe my code on GTK4(may be working).
(I really hate the breaking change of API of 3 to 4...lol)

lcallarec · 2022-11-29T16:09:54Z

Hey @Robert-Ordis, thank you very much for your PR. That's a fact : I don't have so much time, but yeah, you're welcome to create PR. Just : for each new feature, please update the documentation accordingly, add tests (TDD welcome), and avoid API breaks. If you need any API breaks, let discuss together.

If any of you wants to become a maintainer to help me pushing live-chart at the next level, let's talk, I'll be very proud !

By the way, I'll merge this PR soon, sorry for the delay, thank you again.

Robert-Ordis · 2022-11-30T01:42:44Z

Good morning @lcallarec .
I'm glad to receive your reply. (sorry for my bad English if this is hard to read)
Because of my too much piled up modification, reviewing/merging will need a little longer time...(I'm sorry for it)

Avoiding API breaks: I did my work as not to lose compatibility (I think it means becoming unable to reuse "example" code e.g.) carefully at least. But changing the base type of Values (LinkedList->TreeSet) may be so.

Test and documentation: I see. I'll commit the example code for my features.
Does "documentation" mean README.md ?

I see that you'll merge my PR. thx, but then, do I have to rebase to your newest repository?

taozuhong · 2022-11-30T02:01:36Z

do I have to rebase to your newest repository?

Yes, and move forward to GTK4 at best.

lcallarec · 2022-11-30T07:26:08Z

@Robert-Ordis : yes, in order to technically be able to merge your PR, you need to resolve conflicts, whatever the way you do it. You can fix them via the web editor (somewhere below this message, there should be a "This branch has conflicts that must be resolved" block where you'll be able to open the web editor).
Please ask if you need further help.

lcallarec · 2022-11-30T08:03:21Z

yes, by documentation I mean README.md and code / feature examples in examples folder.

If you want to contribute with more PR in the future, I think it'll be a good idea to make a PR per feature. It's smaller, simpler to read and review and therefore will be easier and quicker to merge.

lcallarec · 2022-11-30T08:04:22Z

examples/live-chart.vala

+			chart.remove_serie(rss);
+			return false;
+		});
+


Will be a nice if we could have a button to remove that serie instead of waiting 20s

lcallarec · 2022-11-30T08:08:38Z

src/chart.vala

+        public void remove_all_series(){
+            this.series.remove_all();
+        }
+


That kind of API improvements should be added to README.

lcallarec · 2022-11-30T08:12:27Z

src/chart.vala

+                    this.prev_time = now;
+                    this.queue_draw();
+                    return true;
+                });


Documentation is welcome :)

lcallarec · 2022-11-30T08:14:39Z

src/chart.vala

        }

        private bool render(Gtk.Widget _, Context ctx) {
-
+            ctx.set_antialias(Cairo.Antialias.NONE);


Don't we loose render quality if we disable antialias ?

Sorry to forgot to revert it. It's my mistake.

lcallarec · 2022-11-30T08:15:32Z

src/config.vala

+			set{
+				if(_width != value){
+					//i = config.width - config.padding.right; i > config.padding.left; i -= config.x_axis.tick_length
+					if(x_axis.tick_length <= 0.0){


If it's commented, it's certainly useless :)

lcallarec · 2022-11-30T08:22:46Z

src/series.vala

+            foreach(var entry in signals){
+                entry.key.disconnect(entry.value);
+            }
+        }


Yes, very cool, you fixed lots of possible memory leaks 👍

Robert-Ordis · 2022-11-30T10:30:51Z

Thanks for revieweing my noob-like PR...
Then, I'd like to make my modifications tidy up once. (Including the features not pushed here yet)
In this case, what should I do to my mods for Gtk4 ?
(#37 is still waiting for being merged)

P.S.
I'd like to keep this PR till next PR.

Robert-Ordis · 2022-12-01T06:16:48Z

Started first (#38).

@taozuhong
How do I treat my mods for Gtk4 ?(maybe conflicting between mine and yours)

taozuhong · 2022-12-01T06:21:20Z

Put your mods based on GTK4 if your app has been ported to GTK4, or focus on GTK3 full time, then upgrade to GTK4 branch.

Caution of memory leak.

Robert-Ordis · 2022-12-07T08:56:08Z

Started 2nd (#39).

Robert-Ordis · 2022-12-09T08:49:37Z

Started 3/10 (#40)

Robert-Ordis added 10 commits March 3, 2022 00:08

[Chart-Serie: modify] Now, Serie is removable from Chart/Series.

b368afd

[live-chart: modify] Safety for refresh-rate/Stop using anti-aliasing…

32820ac

…(for my own use)

[Chart: modify] - Add new function to remove all series from chart.

020246d

[Chart: fix] - Fix the issue causing memory leak on removing Chart fr…

0965228

…om widget. -> Caused by circular reference between Chart and Series.

[LiveChart: experiment] - Make livechart rewindable.

1882f91

[dependency: examination] - Try adapting to Gtk4. (but may not be rec…

d135c57

…ommended)

[Chart: fix] - The issue delaying "the newest time" from real-time.

f6bbf62

[Chart: tweak] - Change time counting method to GLib.get_monotonic_ti…

065da7a

…me(). -> To avoid warping time-diff by NTP.

[Points - Values: mod] Changed from List to TreeSet.

f9bc1f8

- To reduce draw call by limiting the range efficiently(?) with using RBST. - I encountered a problem by pushing values with random timepoint on List.

[test-code: commit] Forgot to commit

5ecbe36

[Points: fix] Make test passable.

03c963b

taozuhong reviewed Nov 29, 2022

View reviewed changes

lcallarec reviewed Nov 30, 2022

View reviewed changes

src/chart.vala

this.prev_time = now;

this.queue_draw();

return true;

});

Copy link

Owner

lcallarec Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is welcome :)

lcallarec reviewed Nov 30, 2022

View reviewed changes

Robert-Ordis changed the title ~~From my own purpose.~~ [will be dropped]From my own purpose. Dec 1, 2022

Update README.md

35b69a4

Caution of memory leak.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[will be dropped]From my own purpose. #32

[will be dropped]From my own purpose. #32

Robert-Ordis commented Mar 7, 2022

Robert-Ordis commented Mar 7, 2022 •

edited

Loading

lcallarec commented Mar 7, 2022

Robert-Ordis commented Mar 8, 2022

Robert-Ordis commented Nov 29, 2022

taozuhong Nov 29, 2022

Robert-Ordis Nov 29, 2022

lcallarec Nov 30, 2022

taozuhong commented Nov 29, 2022

Robert-Ordis commented Nov 29, 2022 •

edited

Loading

stsdc commented Nov 29, 2022

Robert-Ordis commented Nov 29, 2022

taozuhong commented Nov 29, 2022 •

edited

Loading

Robert-Ordis commented Nov 29, 2022

lcallarec commented Nov 29, 2022

Robert-Ordis commented Nov 30, 2022 •

edited

Loading

taozuhong commented Nov 30, 2022

lcallarec commented Nov 30, 2022 •

edited

Loading

lcallarec commented Nov 30, 2022

lcallarec Nov 30, 2022

lcallarec Nov 30, 2022

lcallarec Nov 30, 2022

lcallarec Nov 30, 2022

Robert-Ordis Nov 30, 2022

lcallarec Nov 30, 2022

lcallarec Nov 30, 2022

Robert-Ordis commented Nov 30, 2022 •

edited

Loading

Robert-Ordis commented Dec 1, 2022

taozuhong commented Dec 1, 2022

Robert-Ordis commented Dec 7, 2022

Robert-Ordis commented Dec 9, 2022

[will be dropped]From my own purpose. #32

Are you sure you want to change the base?

[will be dropped]From my own purpose. #32

Conversation

Robert-Ordis commented Mar 7, 2022

Robert-Ordis commented Mar 7, 2022 • edited Loading

lcallarec commented Mar 7, 2022

Robert-Ordis commented Mar 8, 2022

Robert-Ordis commented Nov 29, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taozuhong commented Nov 29, 2022

Robert-Ordis commented Nov 29, 2022 • edited Loading

stsdc commented Nov 29, 2022

Robert-Ordis commented Nov 29, 2022

taozuhong commented Nov 29, 2022 • edited Loading

Robert-Ordis commented Nov 29, 2022

lcallarec commented Nov 29, 2022

Robert-Ordis commented Nov 30, 2022 • edited Loading

taozuhong commented Nov 30, 2022

lcallarec commented Nov 30, 2022 • edited Loading

lcallarec commented Nov 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Robert-Ordis commented Nov 30, 2022 • edited Loading

Robert-Ordis commented Dec 1, 2022

taozuhong commented Dec 1, 2022

Robert-Ordis commented Dec 7, 2022

Robert-Ordis commented Dec 9, 2022

Robert-Ordis commented Mar 7, 2022 •

edited

Loading

Robert-Ordis commented Nov 29, 2022 •

edited

Loading

taozuhong commented Nov 29, 2022 •

edited

Loading

Robert-Ordis commented Nov 30, 2022 •

edited

Loading

lcallarec commented Nov 30, 2022 •

edited

Loading

Robert-Ordis commented Nov 30, 2022 •

edited

Loading