Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow instantiating corrections with different constructors #87

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mroguljic
Copy link
Contributor

No description provided.

@lcorcodilos
Copy link
Owner

@mroguljic I'm finally getting the chance to look at this. Can you explain briefly the intention of isNewConstr and put a description in the docstring with a new @param line?

My only other question is about the changes to setup.py to change to >=. There are some issues doing this with python 2.7. As you can see from the failing GitHub tests, it's trying to use a version of pandas using f string formatting that doesn't work in python 2.7.

Of course, if CMS has finally released a CMSSW version with python 3+ROOT that works and is now standard, we can ignore that :-)

@mroguljic
Copy link
Contributor Author

@lcorcodilos
isNewConstr was placed so I can instantiate a Correction object which uses the same main function as some already created Correction, but with different arguments provided to the constructor which usually initializes the file/histogram needed for correction. Example of the usage can be found here: https://github.com/mroguljic/Zbb_SF/blob/v1/templateMaker.py#L165-L166

As far as I'm aware, the isClone flag does not provide this option. If this makes sense, I'll go ahead and document this as you proposed.

Regarding the setup.py. I was not aware this was bundled in the PR and it shouldn't be here. This was me trying to test python3 installation. Indeed, there is now a setup which works with CMSSW_12_X and python3. I'll make a separate PR for this once we resolve the first item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants