Remove trailing whitespaces from scripts #115
Conversation
|
Precheck success! Next we should activate the regular testing to make sure all is well there. You can do this manually by signing in to CIVET using your GitHub credentials (upper right) and navigating to this page to press the activate button, or the collaborator option I mentioned earlier (then I can activate the tests myself and they will auto-start for me in future PRs). |
|
@dcurreli FYI - I have turned on automatic devel branch merges to master on CIVET. You will need to add the @moosebuild user as an external collaborator to CRANE with Write permissions in order for it to fully work. When you have time, let's proceed with testing on this PR, so we can confirm everything else is working well. |
|
@cticenhour I have added @moosebuild as an external collaborator to CRANE with write permissions. |
|
Great - did you activate testing as well? If not, please activate the testing through CIVET (see below for an example from MOOSE, showing the "Activate all Jobs" button when clicking on the testing Event), or add me as a Collaborator to CRANE in order to automatically activate it. 
|
|
@cticenhour Just added you as a Collaborator to the CRANE repo with Write permission. |
cticenhour
force-pushed
the
fixup-py-whitespace
branch
from
7c27a8e
to
3991846
Compare
This was causing a warning in debug builds
cticenhour
force-pushed
the
fixup-py-whitespace
branch
from
3991846
to
8fbc838
Compare
|
@dcurreli I was just notified by one of our CIVET administrators that you need to give application permission to CIVET to finish this off (there was an error in the logs related to this PR that this should resolve). The request should be in your email! Otherwise, testing is activated and proceeding: https://civet.inl.gov/pr/19710/ |
|
@dcurreli CI tests are passing, so this PR is ready for review and merge, independent of the CIVET issue above. That can be discussed further in our email exchange. |
|
Great. |
|
@smpeyres Pinging for a review and merge. See testing status at https://civet.inl.gov/pr/19710/ |
|
Looks good! @cticenhour What do now regarding CIVET? |
|
Everything related to automated testing works well now. We'll find out about automatic merges from |
Refs #86
@dcurreli It appears as though there was a delay in CI for #114. See those results here: https://civet.inl.gov/pr/19708/. Still have a couple failures that my last run-through missed. Let's see how this one does.
In order for testing to auto-start for me (and not require manual activation on your part), you will need to add me as an outside collaborator of CRANE in the repository Settings menu.