fix: prefer default links except on ancient Vim versions #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the suggestion posted in: leafgarland#193 (comment) Which aligns the plugin with what other popular plugins that override bundled syntax files do. eg. - https://github.com/plasticboy/vim-markdown (uses `hi def link` on version 508 and above) - https://github.com/tpope/vim-markdown (uses `hi def link` unconditionally) This stops highlighting from getting obliterated when activating a colorscheme that uses `:hi clear` (which will reset highlights back to defaults), such as a Base16 theme: - https://github.com/chriskempson/base16-vim/blob/3be3cd82cd31acfcab9a41bad853d9c68d30478d/colors/base16-one-light.vim#L146 or Dracula: - https://github.com/dracula/vim/blob/b2cc39273abbb6b38a3d173d2a5d8c2d1c79fc19/colors/dracula.vim#L19-L24 and presumably others.
wincent
added a commit
to wincent/wincent
that referenced
this pull request
Oct 7, 2023
By (hopefully temporarily) switching to my fork: - https://github.com/wincent/typescript-vim If upstream PR gets merged: - leafgarland/typescript-vim#203 or alternative solution is implemented, I can drop the fork. * aspects/nvim/files/.config/nvim/pack/bundle/opt/typescript-vim 31ede5a...169f678 (1): > fix: prefer default links except on ancient Vim versions
leafgarland
approved these changes
Oct 8, 2023
wincent
added a commit
to wincent/wincent
that referenced
this pull request
Oct 17, 2023
Now that PR has been merged: - leafgarland/typescript-vim#203 * aspects/nvim/files/.config/nvim/pack/bundle/opt/typescript-vim 169f678...eafdcf5 (1): > Merge pull request #203 from wincent/def-links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggestion posted in:
Which aligns the plugin with what other popular plugins that override bundled syntax files do. eg.
hi def linkon version 508 and above)hi def linkunconditionally)This stops highlighting from getting obliterated when activating a colorscheme that uses
:hi clear(which will reset highlights back to defaults), such as a Base16 theme or Dracula, and presumably others.May be easier to view with whitespace changes off.