Update tests to the new backend changes #29
Conversation
fahimalizain
changed the title
| expect(r.success).to.be.false; | ||
| }); | ||
| // v13 - doesnt throw error now. It just prints message that the user is assigned already | ||
| // it("should fail assigning same doc to a User since already assigned", async function() { |
There was a problem hiding this comment.
@assemmarwan this update came in v13 - that no error is thrown when duplicate assignments are made, what should we do ?
There was a problem hiding this comment.
@faztp12 I think we can introduce a new test when testing against v13 that will not throw error if a same user is assigned. While the <v12 test will be skipped. And vice versa, what do you think?
| @@ -1045,7 +1038,8 @@ describe("Frappe Model Controller", function() { | |||
| expect(getTags.success).to.be.true; | |||
|
|
|||
| expect(getTags.data).to.an.instanceOf(Array); | |||
| expect(getTags.data.length).to.be.equal(0); | |||
| // TODO: update this after frappe fixes get_tags | |||
| // expect(getTags.data.length).to.be.equal(0); | |||
There was a problem hiding this comment.
@assemmarwan well, frappe still hasnt fixed the tags bug 🤦 😄
| @@ -34,7 +34,8 @@ describe("File Utils", function() { | |||
| path.join(__dirname, "..", "tests", "sample.txt") | |||
| ); | |||
| expect(fileResult.fileName).to.be.equal("sample.txt"); | |||
| expect(fileResult.fileSize).to.be.equal(27); | |||
| expect(fileResult.fileSize).to.be.gte(24); | |||
There was a problem hiding this comment.
@assemmarwan looks like the file checked out on windows and checked out on unix systems are a byte different ?
There was a problem hiding this comment.
I see, please add a comment mentioning that to avoid confusion.
|
@faztp12 Please add tests for |
Everything else passes successfully in this suite