fix: throws when fetching object without id (#641)

leancloud · Mar 17, 2021 · ef4cc3e · ef4cc3e
1 parent ead0d9d
commit ef4cc3e
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/src/file.js b/src/file.js
@@ -619,6 +619,9 @@ module.exports = function(AV) {
        *     completes.
        */
       fetch(fetchOptions, options) {
+        if (!this.id) {
+          throw new Error('Cannot fetch unsaved file');
+        }
         var request = AVRequest(
           'files',
           null,

diff --git a/src/object.js b/src/object.js
@@ -946,6 +946,9 @@ module.exports = function(AV) {
        *     completes.
        */
       fetch: function(fetchOptions = {}, options) {
+        if (!this.id) {
+          throw new Error('Cannot fetch unsaved object');
+        }
         var self = this;
         var request = _request(
           'classes',

diff --git a/test/file.js b/test/file.js
@@ -188,6 +188,10 @@ describe('File', function() {
           .fetch()
           .then(file => (this.file = file));
       });
+      it('should throws when objectId is empty', () => {
+        const file = new AV.File('filename', { base64: 'dGVzdA==' });
+        expect(file.fetch).throwError();
+      });
       it('should retrieve all data', function() {
         var file = this.file;
         expect(file).to.be.a(AV.File);

diff --git a/test/object.js b/test/object.js
@@ -447,6 +447,10 @@ describe('Objects', function() {
           expect(score.createdAt).to.be.a(Date);
           expect(score.id).to.be.eql(gameScore.id);
         }));
+    it('should throws when objectId is empty', () => {
+      const object = new AV.Object('GameScore');
+      expect(object.fetch).throwError();
+    });
     it('fetch should remove deleted keys', () => {
       const getFakedScore = () =>
         AV.parseJSON(