Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): isTicketEnabled should be optional #931

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

leeyeh
Copy link
Contributor

@leeyeh leeyeh commented Jul 21, 2023

图片

这个选项感觉没有理由「必填」,不知道是不是有什么特殊的考量? @fareco

@leeyeh leeyeh requested a review from fareco July 21, 2023 11:39
@fareco
Copy link
Contributor

fareco commented Jul 24, 2023

嗯没有特别的考虑, 改成 optional 就好

@leeyeh leeyeh merged commit 2f624b2 into master Jul 24, 2023
@leeyeh leeyeh deleted the fix/optional-ticket-enabled branch July 24, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants