-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Add MimeType for appimage and metainfo file support #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prateekmedia
commented
Jun 14, 2024
•
edited
Loading
edited
- MimeType was missing from appimage packaging, it is similarly implemented as done for deb and rpm.
- Implement Metainfo file parameter support, which is used by all of the major apps and it tells about the metadata of the app used by appstores and flathub. Reference: Add support to specify metainfo or path of metainfo for linux #174
- Pubspec.lock shoudn't be commited and it should be gitignored, I have deleted so that it is the correct behavior.
- Update example in hello_world
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Please provide an example that you could add to examples/hello_wolrd. Can you add usage doc? |
@lijy91 Done! Please check now. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.