Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Topological properties of order-connected sets in ℝⁿ #10565

Closed
wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Feb 14, 2024

@YaelDillies YaelDillies added awaiting-review mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged t-analysis Analysis (normed *, calculus) t-order Order theory labels Feb 14, 2024
@urkud urkud self-assigned this Feb 14, 2024
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Feb 15, 2024
@YaelDillies YaelDillies added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 15, 2024
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Feb 19, 2024
@YaelDillies YaelDillies added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Feb 21, 2024
@YaelDillies YaelDillies requested a review from urkud March 2, 2024 12:43
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Mar 8, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Mar 17, 2024
@YaelDillies YaelDillies added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Mar 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Mar 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward, modulo the removal of Topology.Order.Bounded

Mathlib/Topology/Order/Bornology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Order/Bounded.lean Show resolved Hide resolved
Copy link

github-actions bot commented Jun 7, 2024

Import summary

Dependency changes
File Base Count Head Count Change
Mathlib.Analysis.Normed.Order.UpperLower 1150 1153 +3 (+0.26%)

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

github-actions bot commented Jun 7, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment. Feel free to merge even if you disagree.

bors d+

Mathlib/Analysis/Normed/Order/UpperLower.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 7, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Comment on lines +28 to +31
Is there a way to generalise `IsClosed.upperClosure_pi`/`IsClosed.lowerClosure_pi` so that they also
apply to `ℝ`, `ℝ × ℝ`, `EuclideanSpace ι ℝ`? `_pi` has been appended to their names to disambiguate
from the other possible lemmas, but we will want there to be a single set of lemmas for all
situations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment shouldn't hold up this PR, but the relevant lemmas could just take a homeomorphism with a pi-type as an explicit argument. It's not a pretty solution, but I think it would work, and I believe we already have the necessary homeomorphisms available.

(On second thought, would it need to be an order isomorphism too? That probably rules out this idea as being useful)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it would also need to be an order isomorphism. That's the crux. We need a way to say "Order on this type is given by those coordinates", which sounds a lot like the Inducing/Embedding business in the topology part of the library.

Food for thought, I guess

@YaelDillies YaelDillies removed the request for review from urkud June 7, 2024 18:08
@YaelDillies
Copy link
Collaborator Author

bors merge

Copy link

github-actions bot commented Jun 7, 2024

PR summary

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.Normed.Order.UpperLower 1150 1153 +3 (+0.26%)

Diff of declarations

+ BddAbove.isBounded
+ BddAbove.isBounded_inter
+ BddBelow.isBounded
+ BddBelow.isBounded_inter
+ Bornology.IsBounded.bddAbove
+ Bornology.IsBounded.bddBelow
+ Bornology.IsBounded.subset_Icc_sInf_sSup
+ IsClopen.lowerClosure_pi
+ IsClopen.upperClosure_pi
+ IsClosed.lowerClosure_pi
+ IsClosed.upperClosure_pi
+ IsOrderBornology
+ OrderDual.instIsOrderBornology
+ Pi.instIsOrderBornology
+ Prod.instIsOrderBornology
+ _root_.BddAbove.isBoundedUnder
+ _root_.BddBelow.isBoundedUnder
+ bddAbove_preimage_ofDual
+ bddAbove_preimage_toDual
+ bddBelow_preimage_ofDual
+ bddBelow_preimage_toDual
+ closure_lowerClosure_comm_pi
+ closure_upperClosure_comm_pi
+ dist_anti_left_pi
+ dist_anti_right_pi
+ dist_inf_sup_pi
+ dist_le_dist_of_le_pi
+ dist_mono_left_pi
+ dist_mono_right_pi
+ instBornology
+ instIsOrderBornology
+ isBounded_iff_bddBelow_bddAbove
+ isBounded_preimage_ofDual
+ isBounded_preimage_toDual
+ isCobounded_preimage_ofDual
+ isCobounded_preimage_toDual
+ isOrderBornology_iff_eq_orderBornology
+ lowerClosure_interior_subset'
+ orderBornology
+ orderBornology_isBounded
+ upperClosure_interior_subset'
- Real.isBounded_iff_bddBelow_bddAbove
- Real.subset_Icc_sInf_sSup_of_isBounded

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 7, 2024

Canceled.

@YaelDillies
Copy link
Collaborator Author

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 7, 2024

Build failed (retrying...):

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 7, 2024

Build failed (retrying...):

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Topological properties of order-connected sets in ℝⁿ [Merged by Bors] - feat: Topological properties of order-connected sets in ℝⁿ Jun 8, 2024
@mathlib-bors mathlib-bors bot closed this Jun 8, 2024
@mathlib-bors mathlib-bors bot deleted the YK-Yael-normed-order branch June 8, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged t-analysis Analysis (normed *, calculus) t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants