-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Algebra/Order/GroupWithZero/Unbundled): deprecate useless lemmas, use ZeroLEOneClass
#17593
base: master
Are you sure you want to change the base?
Conversation
PR summary b0223e31bbImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
The history of this PR is so long that I don't know what happened, but I added and removed some `@[deprecated]`.
I split the part that adds lemmas as #17623. |
This PR/issue depends on:
|
There are still some useless lemmas that were simply ported from
Algebra.Order.Monoid.Lemmas
, such as just chain an existing lemma with an assumption and lemmas whose assumptions imply1 ≤ 0
. This PR removes them.Also, some lemmas have both assumptions like
1 < a
0 < a
. This PR usesZeroLEOneClass
to remove redundant assumptions.Ported from leanprover-community/mathlib3#16525 and leanprover-community/mathlib3#18158
Adapted from #9250. This version is easier to review.