Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Algebra/Order/GroupWithZero/Unbundled): deprecate useless lemmas, use ZeroLEOneClass #17593

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

FR-vdash-bot
Copy link
Collaborator

@FR-vdash-bot FR-vdash-bot commented Oct 9, 2024

There are still some useless lemmas that were simply ported from Algebra.Order.Monoid.Lemmas, such as just chain an existing lemma with an assumption and lemmas whose assumptions imply 1 ≤ 0. This PR removes them.

Also, some lemmas have both assumptions like 1 < a 0 < a. This PR uses ZeroLEOneClass to remove redundant assumptions.


Ported from leanprover-community/mathlib3#16525 and leanprover-community/mathlib3#18158

Adapted from #9250. This version is easier to review.

Open in Gitpod

@FR-vdash-bot FR-vdash-bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 9, 2024
@FR-vdash-bot FR-vdash-bot added the t-order Order theory label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

PR summary b0223e31bb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Left.one_le_mul₀
+ Left.one_lt_mul_of_le_of_lt₀
+ Left.one_lt_mul_of_lt_of_le₀
+ Left.one_lt_mul₀
+ Right.one_le_mul₀
+ Right.one_lt_mul_of_le_of_lt₀
+ Right.one_lt_mul_of_lt_of_le₀
+ Right.one_lt_mul₀
+ mul_le_one_left₀
+ mul_le_one_right₀
+ mul_lt_one_of_le_of_lt_of_pos_left
+ mul_lt_one_of_le_of_lt_right₀
+ mul_lt_one_of_le_of_lt₀
+ mul_lt_one_of_lt_of_le_left₀
+ mul_lt_one_of_lt_of_le_of_pos_right
+ mul_lt_one_of_lt_of_le₀
+ one_lt_mul₀

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

The history of this PR is so long that I don't know what happened, but I added and removed some `@[deprecated]`.
@FR-vdash-bot
Copy link
Collaborator Author

I split the part that adds lemmas as #17623.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 10, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 22, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 23, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc) t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants