-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Eventual boundedness of neighborhoods #8009
Conversation
refine ⟨fun x ↦ ?_⟩ | ||
obtain ⟨a, ha⟩ := isBounded_ge_nhds x.1 | ||
obtain ⟨b, hb⟩ := isBounded_ge_nhds x.2 | ||
rw [← @Prod.mk.eta _ _ x, nhds_prod_eq] | ||
exact ⟨(a, b), ha.prod_mk hb⟩ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of copying the proof, you can deduce it from the other one by order-dual arguments, with something like
refine ⟨fun x ↦ ?_⟩ | |
obtain ⟨a, ha⟩ := isBounded_ge_nhds x.1 | |
obtain ⟨b, hb⟩ := isBounded_ge_nhds x.2 | |
rw [← @Prod.mk.eta _ _ x, nhds_prod_eq] | |
exact ⟨(a, b), ha.prod_mk hb⟩ | |
⟨(instBoundedLENhdsClassProd (α := αᵒᵈ) (β := βᵒᵈ)).isBounded_le_nhds⟩ |
(if you have named the instance above). Same thing for the next instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a forward-port PR, I think this is best left to a follow-up. The ideal place for this comment would have been leanprover-community/mathlib3#18629!
Co-authored-by: sgouezel <[email protected]>
This looks like a faithful forward-port, so bors merge Please open a follow-up PR to address @sgouezel's concerns. |
Canceled. |
bors merge |
Forward port leanprover-community/mathlib3#18629 Co-authored-by: Eric Wieser <[email protected]>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Forward port leanprover-community/mathlib3#18629