Fix alignment of language buttons in setup flow #13024
Conversation
|
Hi @malviya-rajveer, thanks! Would you please post before/after screenshot? Also for next time, it's best to keep the pull request description template and fill it in as it guides you to provide information that's needed. Also, before working on an issue, next time I'd suggest you ask for an assignment first. See more in the contributing guidelines. |
Build Artifacts
|
|
Hello @MisRob, thank you for reviewing my pull request! I really appreciate your time and feedback. I apologize for not including the before/after screenshots; I understand how important they are for clarity. I'll be sure to follow the pull request description template more closely in the future. I also appreciate your suggestion regarding assignment requests before working on issues. I’ll make sure to refer to the contributing guidelines next time. Thank you for your guidance! |
|
No worries and thank you @malviya-rajveer |
| @@ -149,6 +149,10 @@ | |||
| padding-left: 8px; | |||
| } | |||
| .px-6 { | |||
| padding-bottom: 6px; | |||
There was a problem hiding this comment.
I think we can take this to 2px.
| @@ -48,6 +48,7 @@ | |||
| .px-8 { | |||
| padding-right: 8px; | |||
| padding-bottom: 4px; | |||
|
Hi @malviya-rajveer I left you a few minor comment. From this PR I can still see this |
|
Hi @AllanOXDi, I've implemented the changes you suggested. Please review it thank you!! |
Summary
fixes Fix alignment of language buttons in setup flow #12298
before alignment of languages
After alignment of languages