Feature/improve design of front page #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laur0r
requested changes
Nov 24, 2023
| $this->page->url, | ||
| array('action' => ACTION_DISTRIBUTE_UNALLOCATED_EQUALLY) | ||
| ); | ||
| $buttondisteq = new single_button($distributeunallocatedurleq, |
There was a problem hiding this comment.
The buttons are very large for the German version. The string is longer but it seems the button size is larger than it has to be. Can you have a look at that?
There was a problem hiding this comment.
I think it is not possible to make the buttons smaller manually, since this is just how they look like in this theme with a word wrap. I could give them a fixed size, but that wouldn't look good on different sized windows of the page.
Laur0r
requested changes
Dec 21, 2023
styles.css
Outdated
|
|
||
| .ratingallocate_front_page_buttons { | ||
| margin: auto; | ||
| width: fit-content; |
There was a problem hiding this comment.
This prohibits the alignment of the 'distribute unallocated' buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tables to the main ratingallocate page in order to make the buttons and status information more readable.