Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single-item array in page Contents key #32

Closed
wants to merge 1 commit into from
Closed

Support single-item array in page Contents key #32

wants to merge 1 commit into from

Conversation

oxisto
Copy link

@oxisto oxisto commented Oct 4, 2023

The Contents key can either be a direct reference to an object (stream) or an array. This PR supports the simple case, in which the array contains a single item.

For full support, the streams within the array would need to be concatinated, however, this seems to be a rather special case. This should fix most of the PDFs that failed previously.

Fixes #15
Fixes #24

The `Contents` key can either be a direct reference to an object (stream) or an array. This PR supports the simple case, in which the array contains a single item.

For full support, the streams within the array would need to be concatinated, however, this seems to be a rather special case. This should fix most of the PDFs that failed previously.

Fixes #15
Fixes #24
@oxisto oxisto closed this by deleting the head repository Oct 4, 2023
@ZeusMode
Copy link

What happened? Why you've deleted?

@romanpickl
Copy link

@oxisto I saw that you implemented this in your fork at
oxisto@22dd237

As I run into the same issue today, it would be great if this could be backported to this branch as well.

Do you think that would make sense?

@oxisto
Copy link
Author

oxisto commented Mar 12, 2024

@oxisto I saw that you implemented this in your fork at oxisto@22dd237

As I run into the same issue today, it would be great if this could be backported to this branch as well.

Do you think that would make sense?

I will think about this when I have some more free time. At the point when I closed this PR it seems that this project was abandoned and I need the functionality in one of my projects, so I forked it from the original rsc repo. Since then at least it seems that there was some activity again in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse pdf error Won´t open some PDFs
3 participants