support array of content streams and parse them as a single stream #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanpickl
referenced
this pull request
in oxisto/pdf
Mar 12, 2024
The page object structure supports either a stream or an array in the `Contents` key. In the latter case, we need concat the contents of the individual streams.
|
seems to fix: potentially fixes: the issue in #15 seems to be a broken xref table in the pdf which can be fixed with mutools. |
|
As far as my tests are representative, it now also works with
|
romanpickl
commented
Mar 14, 2024
| tok := b.readToken() | ||
| if tok == io.EOF { | ||
| break | ||
| s := strm |
There was a problem hiding this comment.
maybe there is a more GO like way of doing this without repeating code.
I'm open for suggestions.
|
I can confirm that it fixed Great job @romanpickl ! |
|
can this be merged? |
bloeys
added a commit
to Sabbar-Engineering/pdf
that referenced
this pull request
Dec 18, 2024
Applies patch: ledongthuc#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support array of content streams.
this is based on some work in
Contentskey #32but, as far as I understand the spec, the streams have to be concatenated before they are interpreted i.e. they have to be interpreted as a single stream. Otherwise some streams might be invalid as they depend on e.g. BT ops being opened in the previous stream.
https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf (page 78)
This draft includes some duplication that could be refactored, but I don't have the full visibility of the code base (yet).
In addition I think that other functions like walkTextBlocks might have to be updated as well.