Problem:(CRO-587) no integration test for new validator join tx #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Used `BTreeSet` instead of `Vec`. Fixes crypto-com#840
Solution: - derive hmaced-keys only when create wallet, client pass it around. Add unit testing
…re historical state data solution: each time when chain-abci start, check the last app states stored in `COL_APP_STATES` to force to store historical state data or not.
…he network Solution: - refuse to sync when tendermint catching up. - retry several times to prevent temparary catching up status.
842: Problem crypto-com#831: client sync fails if TM is catching up with the network r=tomtau a=yihuang Solution: - refuse to sync when tendermint catching up. - retry several times for temparary catching up status. Co-authored-by: yihuang <[email protected]>
Solution: Added a more detailed error message. Fixes crypto-com#838
830: Problem(Fix crypto-com#786): client keeps re-deriving hardened key r=tomtau a=yihuang Solution: - derive hmaced-keys only when create wallet, client pass it around. * Use blake2 of wallet name as salt of argon2. 841: Problem: User may enter same view key multiple times in client-cli r=tomtau a=devashishdxt Solution: Used `BTreeSet` instead of `Vec`. Fixes crypto-com#840 843: Problem:(Fix crypto-com#832) random client failing if node didn't store historical state data r=tomtau a=linfeng-crypto issue: crypto-com#832 solution: each time when chain-abci start, check the last app states stored in `COL_APP_STATES` to force to store historical state data or not. Co-authored-by: yihuang <[email protected]> Co-authored-by: Devashish Dixit <[email protected]> Co-authored-by: linfeng <[email protected]>
Solution: Show transaction type in history. This addresses a part of crypto-com#846
845: Problem: Ambiguous error message for empty staking address r=tomtau a=devashishdxt Solution: Added a more detailed error message. Fixes crypto-com#838 Co-authored-by: Devashish Dixit <[email protected]>
848: Problem: Client CLI does not show transaction type in history r=tomtau a=devashishdxt Solution: Show transaction type in history. This addresses a part of crypto-com#846 Sample output after this change: ``` +------------------------------------------------------------------+--------+----------------------+-----+------------------+--------------+--------------------------------+ | Transaction ID | In/Out | Amount | Fee | Transaction Type | Block Height | Block Time | +------------------------------------------------------------------+--------+----------------------+-----+------------------+--------------+--------------------------------+ | cc88d0ca2cbcd6ce167a6db426f40c3da034deb5b4e4f09e5ec01f39af80c0ea | IN | 24999999999.99999703 | - | Withdraw | 92 | 2020-01-07T10:14:17.764748000Z | +------------------------------------------------------------------+--------+----------------------+-----+------------------+--------------+--------------------------------+ ``` Co-authored-by: Devashish Dixit <[email protected]>
leejw51
force-pushed
the
cro-587
branch
3 times, most recently
from
9d0044f to
283adb2
Compare
Codecov Report
@@ Coverage Diff @@
## cro-587-20200108 #1 +/- ##
===================================================
Coverage ? 68.57%
===================================================
Files ? 133
Lines ? 17376
Branches ? 0
===================================================
Hits ? 11916
Misses ? 5460
Partials ? 0
|
836: Problem:(CRO-647)integration test occasionally fails due to tx-query not started up r=tomtau a=linfeng-crypto reason: tx-query fails and crash if the network connection to intel failed, this happens when generating a certification while the first request coming. So when the tx-query starts, using `wait-for-it.sh` to check will pass, but when the first request coming and if the network connection to intel error, tx-query will crash. solution: retry 3 times when `SGX_ERROR_BUSY` error happens. Co-authored-by: linfeng <[email protected]>
leejw51
force-pushed
the
cro-587
branch
2 times, most recently
from
47e6645 to
d20a2ca
Compare
Bumps [num-bigint](https://github.com/rust-num/num-bigint) from 0.2.4 to 0.2.5. - [Release notes](https://github.com/rust-num/num-bigint/releases) - [Changelog](https://github.com/rust-num/num-bigint/blob/master/RELEASES.md) - [Commits](rust-num/num-bigint@num-bigint-0.2.4...num-bigint-0.2.5) Signed-off-by: dependabot-preview[bot] <[email protected]>
872: Bump num-bigint from 0.2.4 to 0.2.5 r=devashishdxt a=dependabot-preview[bot] Bumps [num-bigint](https://github.com/rust-num/num-bigint) from 0.2.4 to 0.2.5. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-num/num-bigint/blob/master/RELEASES.md">num-bigint's changelog</a>.</em></p> <blockquote> <h1>Release 0.2.5 (2020-01-09)</h1> <ul> <li><a href="https://github-redirect.dependabot.com/rust-num/num-bigint/pull/126">Updated the <code>autocfg</code> build dependency to 1.0</a>.</li> </ul> <p><strong>Contributors</strong>: <a href="https://github.com/cuviper">@cuviper</a>, <a href="https://github.com/tspiteri">@tspiteri</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-num/num-bigint/commit/46ce3b470a86befc04097a0daf9cc54475685d94"><code>46ce3b4</code></a> Merge <a href="https://github-redirect.dependabot.com/rust-num/num-bigint/issues/127">#127</a></li> <li><a href="https://github.com/rust-num/num-bigint/commit/eda324427a2ceb48d611be7b7d709451d088a11a"><code>eda3244</code></a> Release 0.2.5</li> <li><a href="https://github.com/rust-num/num-bigint/commit/973337be3d0f10c8407411cc2e37cf77be40ba2a"><code>973337b</code></a> Merge <a href="https://github-redirect.dependabot.com/rust-num/num-bigint/issues/126">#126</a></li> <li><a href="https://github.com/rust-num/num-bigint/commit/cc853b2a7d45730104ac2541cda32151e3937b65"><code>cc853b2</code></a> Update to autocfg 1</li> <li><a href="https://github.com/rust-num/num-bigint/commit/c38a11d802a481d04e059436b69e622dac0dbce3"><code>c38a11d</code></a> Merge <a href="https://github-redirect.dependabot.com/rust-num/num-bigint/issues/125">#125</a></li> <li><a href="https://github.com/rust-num/num-bigint/commit/b2507b0fe2b6891aa16660b7bdffe32b8989c491"><code>b2507b0</code></a> Doc: some minor clarifications and formatting nits</li> <li>See full diff in <a href="https://github.com/rust-num/num-bigint/compare/num-bigint-0.2.4...num-bigint-0.2.5">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=num-bigint&package-manager=cargo&previous-version=0.2.4&new-version=0.2.5) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [tiny-bip39](https://github.com/maciejhirsz/tiny-bip39) from 0.6.2 to 0.7.0. - [Release notes](https://github.com/maciejhirsz/tiny-bip39/releases) - [Changelog](https://github.com/maciejhirsz/tiny-bip39/blob/master/CHANGELOG.md) - [Commits](https://github.com/maciejhirsz/tiny-bip39/commits) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [zxcvbn](https://github.com/shssoichiro/zxcvbn-rs) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/shssoichiro/zxcvbn-rs/releases) - [Changelog](https://github.com/shssoichiro/zxcvbn-rs/blob/master/CHANGELOG.md) - [Commits](shssoichiro/zxcvbn-rs@v2.0.0...v2.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [quickcheck](https://github.com/BurntSushi/quickcheck) from 0.9.0 to 0.9.1. - [Release notes](https://github.com/BurntSushi/quickcheck/releases) - [Commits](BurntSushi/quickcheck@quickcheck_macros-0.9.0...quickcheck_macros-0.9.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
877: Bump tiny-bip39 from 0.6.2 to 0.7.0 r=tomtau a=dependabot-preview[bot] Bumps [tiny-bip39](https://github.com/maciejhirsz/tiny-bip39) from 0.6.2 to 0.7.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/maciejhirsz/tiny-bip39/commits">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=tiny-bip39&package-manager=cargo&previous-version=0.6.2&new-version=0.7.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
878: Bump zxcvbn from 2.0.0 to 2.0.1 r=tomtau a=dependabot-preview[bot] Bumps [zxcvbn](https://github.com/shssoichiro/zxcvbn-rs) from 2.0.0 to 2.0.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/shssoichiro/zxcvbn-rs/blob/master/CHANGELOG.md">zxcvbn's changelog</a>.</em></p> <blockquote> <p><strong>Version 2.0.1</strong></p> <ul> <li>Fix overflow bugs that may cause wrong results on very complex passwords</li> <li>Fix a panic that could occur on passwords with multibyte unicode characters</li> <li>Update <code>derive_builder</code> to 0.9</li> </ul> <p><strong>Version 2.0.0</strong></p> <ul> <li>[Breaking] Update CrackTimes interface to be more idiomatic to Rust (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/pull/24">shssoichiro/zxcvbn-rs#24</a>)</li> <li>Upgrade <code>derive_builder</code> to 0.8</li> <li>Upgrade <code>fancy_regex</code> to 0.2</li> <li>Move to 2018 edition</li> <li>Various internal improvements</li> </ul> <p><strong>Version 1.0.2</strong></p> <ul> <li>Fix building on Rust 1.36.0 (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/pull/21">shssoichiro/zxcvbn-rs#21</a>)</li> <li>Cleanup development profiles which are no longer needed</li> <li>Remove built-in clippy and prefer using clippy from rustup</li> <li>Upgrade <code>itertools</code> to 0.8</li> <li>Upgrade <code>derive_builder</code> to 0.7</li> </ul> <p><strong>Version 1.0.1</strong></p> <ul> <li>Upgrade <code>regex</code> to 1.0</li> </ul> <p><strong>Version 1.0.0</strong></p> <ul> <li>[SEMVER_MINOR] Add support for UTF-8 strings (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/4">shssoichiro/zxcvbn-rs#4</a>)</li> <li>[SEMVER_MAJOR] Remove the <code>ZxcvbnError::NonAsciiPassword</code> variant, since this error can no longer occur</li> </ul> <p><strong>Version 0.7.0</strong></p> <ul> <li>[SEMVER_MAJOR] Refactor <code>Match</code> to use an enum internally, to avoid cluttering the struct with several <code>Option</code> types (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/19">shssoichiro/zxcvbn-rs#19</a>)</li> <li>Make <code>Match</code> public (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/17">shssoichiro/zxcvbn-rs#17</a>)</li> </ul> <p><strong>Version 0.6.3</strong></p> <ul> <li>Refactor handling of strings to use streaming of characters. This brings zxcvbn closer to working on UTF-8 inputs.</li> <li>Fix an issue that would cause bruteforce scores to be too low (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/15">shssoichiro/zxcvbn-rs#15</a>)</li> </ul> <p><strong>Version 0.6.2</strong></p> <ul> <li>Upgrade dependencies and fix linter warnings</li> </ul> <p><strong>Version 0.6.1</strong></p> <ul> <li>Upgrade <code>derive_builder</code> to 0.5.0</li> <li>Fix a bug that was causing incorrect scoring for some passwords (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/13">shssoichiro/zxcvbn-rs#13</a>)</li> </ul> <p><strong>Version 0.6.0</strong></p> <ul> <li>[SEMVER_MAJOR] Change the signature for <code>zxcvbn</code> to take <code>&[]</code> instead of <code>Option<&[]></code> for <code>user_inputs</code> (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/9">shssoichiro/zxcvbn-rs#9</a>)</li> <li>[SEMVER_MAJOR] Change the signature for <code>zxcvbn</code> to return <code>Result<Entropy, ZxcvbnError></code> instead of <code>Option<Entropy></code> (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/11">shssoichiro/zxcvbn-rs#11</a>)</li> </ul> <p><strong>Version 0.5.0</strong></p> <ul> <li>Fix for a BC-breaking change in nightly Rust (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/pull/8">shssoichiro/zxcvbn-rs#8</a>)</li> <li>Upgrade <code>serde</code> to 1.0</li> <li>Silence a warning from <code>derive_builder</code></li> </ul> </tr></table> ... (truncated) </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/7c42b18946457aede0f31b1ca3e46daf76724a8d"><code>7c42b18</code></a> Version 2.0.1</li> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/b6cf15c0d679cb29c97873ab59a2cffa519b4983"><code>b6cf15c</code></a> Readme updates</li> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/81b3acfd5f8882d5278f1ee3bc8876ca5267580a"><code>81b3acf</code></a> Update derive_builder to 0.9</li> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/9ca57222076a8aef7699e24a11a88286225b3c67"><code>9ca5722</code></a> Fix panic that may occur with multibyte unicode chars</li> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/8c4980da65b97ab5997647bf5698ab1ce1c44e9a"><code>8c4980d</code></a> More idiomatic vec initialization</li> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/b195a71612e964208a6c089cec90f758d83373ce"><code>b195a71</code></a> Fix overflow bugs</li> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/b3fc29ac0df7552f4be9aa5fc1454548c3985822"><code>b3fc29a</code></a> Remove intermittently breaking test assertion</li> <li><a href="https://github.com/shssoichiro/zxcvbn-rs/commit/d0cbcd3857d2e55dee32ee0a2d3fc2fcf7ec37d0"><code>d0cbcd3</code></a> Fix repeat detection with multibyte chars (<a href="https://github-redirect.dependabot.com/shssoichiro/zxcvbn-rs/issues/31">#31</a>)</li> <li>See full diff in <a href="https://github.com/shssoichiro/zxcvbn-rs/compare/v2.0.0...v2.0.1">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=zxcvbn&package-manager=cargo&previous-version=2.0.0&new-version=2.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
880: Bump quickcheck from 0.9.0 to 0.9.1 r=tomtau a=dependabot-preview[bot] Bumps [quickcheck](https://github.com/BurntSushi/quickcheck) from 0.9.0 to 0.9.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/BurntSushi/quickcheck/commit/2164959a8cab4501630c498875df1b083653ab00"><code>2164959</code></a> quickcheck_macros-0.9.1</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/2d7049993bf33e18d5f23fc8f6259f6a84688f18"><code>2d70499</code></a> 0.9.1</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/5335d087dd6d61c0003482b7e961959c8eb3c3ac"><code>5335d08</code></a> readme: explicitly document MSRV</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/71c3846f1ac884f18e0599fd42d148d5ba674a92"><code>71c3846</code></a> ci: switch to GitHub Actions</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/ffc0fec983dcf50bf878c6bd8f1d39dba519f1af"><code>ffc0fec</code></a> arbitrary: add impls for Range{To}Inclusive</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/77f9dc753f162125edaaff6bfefb0b1477ce5c06"><code>77f9dc7</code></a> docs: add quick tip for how to impl Arbitrary manually</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/e04889629018d95341b71c696806ab9b27191498"><code>e048896</code></a> arbitrary: add impls for NonZero types</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/5b532a8bd537e20cfbd03b51c79c6a2860881352"><code>5b532a8</code></a> macros: upgrade syn, quote, and proc-macro2 to 1.0</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/2250c91a13da8e670c4639bf57e042d618346952"><code>2250c91</code></a> deps: bump to env_logger 0.7</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/5a3494c06c6797e5ad483a61d9bc5f1ac606fe04"><code>5a3494c</code></a> readme: fix typo</li> <li>See full diff in <a href="https://github.com/BurntSushi/quickcheck/compare/quickcheck_macros-0.9.0...quickcheck_macros-0.9.1">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=quickcheck&package-manager=cargo&previous-version=0.9.0&new-version=0.9.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [rand](https://github.com/rust-random/rand) from 0.7.2 to 0.7.3. - [Release notes](https://github.com/rust-random/rand/releases) - [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-random/rand/commits) Signed-off-by: dependabot-preview[bot] <[email protected]>
879: Bump rand from 0.7.2 to 0.7.3 r=tomtau a=dependabot-preview[bot] Bumps [rand](https://github.com/rust-random/rand) from 0.7.2 to 0.7.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-random/rand/blob/master/CHANGELOG.md">rand's changelog</a>.</em></p> <blockquote> <h2>[0.7.3] - 2020-01-10</h2> <h3>Fixes</h3> <ul> <li>The <code>Bernoulli</code> distribution constructors now reports an error on NaN and on <code>denominator == 0</code>. (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/925">#925</a>)</li> <li>Use <code>std::sync::Once</code> to register fork handler, avoiding possible atomicity violation (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/928">#928</a>)</li> <li>Fix documentation on the precision of generated floating-point values</li> </ul> <h3>Changes</h3> <ul> <li>Unix: make libc dependency optional; only use fork protection with std feature (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/928">#928</a>)</li> </ul> <h3>Additions</h3> <ul> <li>Implement <code>std::error::Error</code> for <code>BernoulliError</code> (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/919">#919</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/rust-random/rand/commits">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=rand&package-manager=cargo&previous-version=0.7.2&new-version=0.7.3) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
leejw51
force-pushed
the
cro-587
branch
2 times, most recently
from
3ddd614 to
829707c
Compare
Other related problems: - (Fix crypto-com#868) compiled enclave file names collide - (Fix crypto-com#870) enclave code not covered by cargo tools - (Fix crypto-com#871) debug/release build result files conflict Solution: - Move compile steps into `build.rs`, only link and sign of enclave so are handled by make. So on linux with sgx sdk setup, all the rust code are built with cargo. - Don't exclude enclave crates from workspace anymore, but not included in default-members, to keep default `cargo build` runnable on mac. After this, - share makefile between tx-validation and tx-query. - use the enclave crate package name as enclave signed so name. - build directory seperated by cargo atomitically - `Cargo.lock` and build directory are shared, faster building. cargo fmt fix integration tests
873: Problem(Fix crypto-com#869): Duplicate enclave makefiles r=tomtau a=yihuang Other related problems: - (Fix crypto-com#868) compiled enclave file names collide - (Fix crypto-com#870) enclave code not covered by cargo tools - (Fix crypto-com#871) debug/release build result files conflict Solution: - Move compile steps into `build.rs`, only link and sign of enclave so are handled by `make`. So on Linux with sgx sdk setup, all the rust codes are built with cargo. - Don't exclude enclave crates from workspace anymore, but not included in default-members, to keep default `cargo build` runnable on mac. After this, - share makefile between tx-validation and tx-query. - use the enclave crate package name as enclave file name. - build directory separated for debug/release by cargo automatically - `Cargo.lock` and build directory are shared between enclave crates and other crates. > The enclave crate name directly determines the library output file name, and if enclave crate name is changed, there are other places need to keep in sync: > - enclave makefile > - enclave app loader code > It's good to use `nightly-2019-11-25` on Linux(the toolchain rust-sgx-sdk requires), you can build all the stuff with it. > Following command can build everything for you, the results are all inside `target/debug`. ``` cargo build cargo build -p tx-validation-app cargo build -p tx-query-app make -C chain-tx-enclave/tx-validation make -C chain-tx-enclave/tx-query ``` Build release version: ``` cargo build --release cargo build -p tx-validation-app --release cargo build -p tx-query-app --release make -C chain-tx-enclave/tx-validation SGX_DEBUG=0 make -C chain-tx-enclave/tx-query SGX_DEBUG=0 ``` The result are inside `target/release` Co-authored-by: yihuang <[email protected]>
leejw51
force-pushed
the
cro-587
branch
2 times, most recently
from
76446b9 to
e6079fe
Compare
Solution: - Fix existing clippy suggestions. - Can't add clippy into travis ci script yet due to lack of sgx sdk
883: Problem (crypto-com#870): There are unfixed clippy suggestions on enclave code r=tomtau a=yihuang Solution: - Fix existing clippy suggestions. - Can't add clippy on enclave into travis ci script yet due to lack of sgx sdk The `cast_ptr_alignment` warning looks suspicious, the correctness dependents on the alignment of `Vec<u8>` pointer, I think normal allocator will produce aligned pointer, so it should be fine normally. Run on linux: ``` $ cargo clippy -p tx-validation-app -p tx-query-app $ cargo clippy -p tx-validation-enclave -p tx-query-enclave ``` Co-authored-by: yihuang <[email protected]>
Bumps [quickcheck](https://github.com/BurntSushi/quickcheck) from 0.9.1 to 0.9.2. - [Release notes](https://github.com/BurntSushi/quickcheck/releases) - [Commits](BurntSushi/quickcheck@quickcheck_macros-0.9.1...0.9.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
889: Bump quickcheck from 0.9.1 to 0.9.2 r=tomtau a=dependabot-preview[bot] Bumps [quickcheck](https://github.com/BurntSushi/quickcheck) from 0.9.1 to 0.9.2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/BurntSushi/quickcheck/commit/6dfb03ab5740e47204acb0151c75f31a6e91bce3"><code>6dfb03a</code></a> 0.9.2</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/33a535f0226cc5c06e07b7e4737961177fcf6b8b"><code>33a535f</code></a> doc: update several links</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/de0e1a0359420ccd3a3f837231b8a4b321a37498"><code>de0e1a0</code></a> readme: fix various links and outdated versions</li> <li><a href="https://github.com/BurntSushi/quickcheck/commit/2fb1de24121a59a32b3515a6243a60d2bb90894e"><code>2fb1de2</code></a> readme: add GitHub Actions badge</li> <li>See full diff in <a href="https://github.com/BurntSushi/quickcheck/compare/quickcheck_macros-0.9.1...0.9.2">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=quickcheck&package-manager=cargo&previous-version=0.9.1&new-version=0.9.2) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
enable drone Update integration-tests/bot/chainrpc.py thanks Co-Authored-By: yihuang <[email protected]> Update integration-tests/bot/chainrpc.py Co-Authored-By: yihuang <[email protected]> turn off join, jail integration test fix enckey fix for enckey tidy up remove SPID, IAS_API_KEY remove spid print remove un-necessary print remove jail.nix in join setup spid, ias_api_key in docker-compose move setting to docker-compose support azure sgx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add join tx integration test
check compile result