Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add string scan support for JSONRawMessage #12

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

lefinal
Copy link
Owner

@lefinal lefinal commented Dec 19, 2023

Now JSONRawMessage accepts both byte slice and string as source, improving the flexibility. Updated corresponding unit tests to reflect this change.

@lefinal lefinal self-assigned this Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8590d9c) 92.68% compared to head (6b480b2) 92.74%.

❗ Current head 6b480b2 differs from pull request most recent head e744f76. Consider uploading reports for the commit e744f76 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   92.68%   92.74%   +0.06%     
==========================================
  Files          16       16              
  Lines         451      455       +4     
==========================================
+ Hits          418      422       +4     
  Misses         22       22              
  Partials       11       11              
Flag Coverage Δ
unittests 92.74% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Now JSONRawMessage accepts both byte slice and string as source, improving the flexibility. Updated corresponding unit tests to reflect this change.
@lefinal lefinal force-pushed the feat-add-string-scan-source-support branch from 6b480b2 to e744f76 Compare December 19, 2023 16:41
@lefinal lefinal merged commit 83392c0 into main Dec 19, 2023
5 checks passed
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant