This repository has been archived by the owner on Nov 18, 2019. It is now read-only.
Remove code which clears dataURL #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In using `angular-signature` we found that clicking on the signature pad repeatedly would cause it to clear out. I tested the `signature_pad` demo and I couldn't reproduce it, but I could reproduce it reliably in the `angular-signature` demo. Doing some debugging it seemed to come from the `timeout` in `updateModel`. When I removed the `isEmpty` check (as in this PR) we found that the problem went away and we didn't see any adverse effects. So we were wondering: what was that code intended to do, and is it still needed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using
angular-signaturewe found that clicking on the signature pad repeatedly would cause it to clear out. I tested thesignature_paddemo and I couldn't reproduce it, but I could reproduce it reliably in theangular-signaturedemo. Doing some debugging it seemed to come from thetimeoutinupdateModel. When I removed theisEmptycheck (as in this PR) we found that the problem went away and we didn't see any adverse effects.So we were wondering: what was that code intended to do, and is it still needed?