Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #100

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

CI improvements #100

wants to merge 15 commits into from

Conversation

gipert
Copy link
Member

@gipert gipert commented Feb 12, 2025

No description provided.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 43.71%. Comparing base (9cf117e) to head (8cd8148).

Files with missing lines Patch % Lines
workflow/src/legenddataflow/execenv.py 20.00% 4 Missing ⚠️
workflow/src/legenddataflow/utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   43.73%   43.71%   -0.03%     
==========================================
  Files          17       17              
  Lines        1150     1153       +3     
==========================================
+ Hits          503      504       +1     
- Misses        647      649       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

workflow/Snakefile-build-raw Outdated Show resolved Hide resolved
@gipert
Copy link
Member Author

gipert commented Feb 12, 2025

@ggmarshall can you spot the problem? If you fix it then it's good to merge. Unfortunately --touch does not touch non-existing files -> that's something we can easily add to the plugin.

But is touching output files smart? Do we code in the Snakefiles that needs to interact with non-dummy outputs?

@gipert gipert marked this pull request as ready for review February 12, 2025 21:33
@gipert
Copy link
Member Author

gipert commented Feb 12, 2025

I have to implement something to make the test output more readable...

@gipert gipert requested a review from ggmarshall February 12, 2025 21:46
@gipert gipert linked an issue Feb 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test dataprod scripts in CI
2 participants