Added routines for calibrating the LQ parameter #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines a general class that contains the different functions used during the calibration process, in a similar manner to AoE_cal.py. A few plotting functions are redundant with those found in AoE_cal.py. We should consider generalizing some of these plotting functions in the future for other PSD parameters.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
- Coverage 19.20% 18.17% -1.04%
==========================================
Files 31 33 +2
Lines 6479 7149 +670
==========================================
+ Hits 1244 1299 +55
- Misses 5235 5850 +615 ☔ View full report in Codecov by Sentry. |
ggmarshall
suggested changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a general class that contains the different functions used for calibrating the Late Charge (LQ) parameter, in a similar manner to AoE_cal.py. A few plotting functions are redundant with those found in AoE_cal.py. We should consider generalizing some of these plotting functions in the future for other PSD parameters.
There are some improvements to be made in the future, but these routines are stable enough that it's worth implementing as things currently are. The routines have been tested individually on all detectors with no issues. However, I'll leave as a draft as there may be some small edits to make and it needs testing with the main data production.