-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-commit versions and contributing doc #67
Conversation
@aazuspan, a few notes on this implications of this commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @grovduck, thanks for updating the pre-commits and getting everything back in order!
I think I had omitted the hatch run
from the pre-commit instructions with the thought that it's not needed if you've activated the shell, but now it looks like the instructions will work whether or not the shell is activated, so definitely an improvement!
My editor did a lot of reformatting of the pyproject.toml file which I attribute to the swap of black for ruff-format?
I'm not sure that ruff-format
will work on toml
files - I tried manually running ruff-format
on the file and it just skipped it. But whatever made the changes, they look better to me!
I've changed this to return IO[str] rather than TextIO. Some discussion of this python/typeshed#283.
Good to know, thanks for the reference!
Ah, thanks for that clarification. Then I'm guessing it must be a VSCode TOML extension I'm using ( |
That makes sense - yeah, I'd say keep the changes! We could add a TOML formatter to the pre-commit, but it changes so infrequently I'm not sure it's the effort. |
Per changes made in
sknnr-spatial
, update the pre-commit versions to latest versions.ruff: v0.3.2
mypy: v1.9.0
In addition, remove the use of
black
as a pre-commit hook and instead rely onruff-format
. Also, updatecontributing.md
to show command use withhatch
and to align it with the contributing guide forsknnr-spatial
.