Update mlua 10.0 and deprecate rlua #90
Conversation
Update example mains
Update other dependencies Remove rlua (deprecated in favor to mlua) Small code cleanups Fix tests
|
The title says "deprecate rlua" but it seems to be entirely removed instead? Edit: not that I disagree with deprecating rlua, as yes, the crate itself is deprecated. But I do think that releasing one version where it is properly marked as deprecated is a better warning than straight up removal right of the bat? |
|
I've tried upgrading only mlua to 10.0 and let rlua to 19.0 but the implementation is way too different now. |
|
Fair. I will look at it more during the weekend. |
|
Didn't have nearly as much time as I wanted. So, didn't really get to it. One question though: Can it be made such that the old path is still valid? I have a private version of tealr where I play with piccolo support. So, eventually (hopefully at least) the I am fine with the movement of all the code itself though. It will probably be quite a while before the piccolo backend can be merged proper and until then there is no reason to pretend there is another backend. |
|
I don't realy understand your question. Maybe change the destination branch of this PR to a new one, then apply any changes you want and submite a new PR. |
|
Disregard my last comment. No idea why I thought you got rid of the Anyway, managed to look better at the code. Fixed the problems caught in CI and ported tealsql over to it. Still need to make a couple of changes and then I am going to see if tealr_doc_gen works with the new version. Assuming everything works then I can do a new release tomorrow. |
|
Thank you for your help in getting this done! 🎉 |
MLua just got an update to version 10.0 that fully remove
'lualifetime and much more.RLua version 20.0 is now deprecated and merged into MLua (rlua re-export mlua modules).
Maybe it's a good time to bump tealr version