Changes In both the Chrome and Firefox imports: #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Add a space after ":ref:". Your "search" code expects a space after ":ref:" I think it is likely that when you wrote and used the import code, you didn't want the space, but later you added a space and failed to update the imports. 2) Change ":added:" to "date-added: " Same reasoning as 1)
|
Good catch! Thanks. I'll go along with this PR, although I'm not the one to approve it. (Nice to know that someone is looking at the app!) In daily life, I use a slightly different outline, which I refactored a little to make the version I posted here. I suppose I forgot to update this one when I changed the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a space after ":ref:". Your "search" code expects a space after ":ref:" I think it is likely that when you wrote and used the import code, you didn't want the space, but later you added a space and failed to update the imports.
Change ":added:" to "date-added: "
Same reasoning as 1)