Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

feat: Village composition display & commandline simplification #42

Closed

Conversation

TheOptimisticFactory
Copy link
Contributor

@TheOptimisticFactory TheOptimisticFactory commented Apr 15, 2020

Main changes

  • /lg start and /lg end can now be called with and without a player name
  • The village composition is now displayed when the game ends, and the winners names are showcased in the chat window when applicable

image


For those interested, my fork (https://github.com/TheOptimisticFactory/LoupGarou/tree/dev) includes

@leomelki
Copy link
Owner

Désolé mais je ne peux pas accepter ton pull request car toutes les modifications aux messages doivent être faites et approuvées par Shytoos qui s'occupe du game design :/

N'ayant pas réellement le temps actuellement, je ne peux pas vérifier que ça corresponde.

@TheOptimisticFactory
Copy link
Contributor Author

TheOptimisticFactory commented Apr 18, 2020

Tous les messages sont affichés dans le chat (cf. l'image rajoutée dans la description de la PR)

@leomelki
Copy link
Owner

leomelki commented Apr 18, 2020

Pas mal 😁
Je verrais pour y apporter qq petites modifs et merge ça quand j'aurais le temps ^^

(rappel pour moi : régler l'ordre des rôles, changer le système de spacer)

@TheOptimisticFactory TheOptimisticFactory changed the title [FEATURE] Village composition display & commandline simplification feat: Village composition display & commandline simplification Apr 19, 2020
@TheOptimisticFactory TheOptimisticFactory force-pushed the master branch 2 times, most recently from 86deefa to 63d2711 Compare April 24, 2020 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants