-
-
Notifications
You must be signed in to change notification settings - Fork 659
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
809eb82
commit 19d0254
Showing
6 changed files
with
45 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19d0254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leongersen just curious if there is a specific reason the latest version is
14.0.0
instead of13.1.6
?From the release notes https://github.com/leongersen/noUiSlider/releases it doesn't seem to have new features or breaking changes - only bug fixes and updated documentation?
Anyway keep up the good work and thanks for sharing this plugin with us! 👍
19d0254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjarnef It's very minor, but
change
&slide
now fire on keyboard interaction. This would break code that relied on those events not firing. I doubt this would affect anyone, but I try to respect semver as close as possible.I'm glad you like the library! Are you using it anywhere public I can look at?
19d0254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leongersen okay, fair enough. Thanks for the explanation 😃
Yes, it is been used in the open source .NET CMS Umbraco. https://our.umbraco.com/download/
First it was implemented as Slider datatype (property editor) and replaced the previous Bootstrap slider.
Later I updated the slider used in the Image Cropper to re-use the slider angular component (using noUiSlider) so it feels a bit more consistent.
umbraco/Umbraco-CMS#4487