Skip to content

Commit

Permalink
Minor fixes, remove minified versions
Browse files Browse the repository at this point in the history
  • Loading branch information
leongersen committed Sep 24, 2013
1 parent 897e0af commit 3d28bcf
Show file tree
Hide file tree
Showing 6 changed files with 282 additions and 174 deletions.
66 changes: 47 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# noUiSlider
_Current version: 4.0.0_
_Current version: 4.0.2_

noUiSlider is a super tiny jQuery plugin that allows you to create range sliders.
It fully supports touch, and it is way(!) less bloated than the jQueryUI library.
Expand All @@ -8,32 +8,60 @@ A full documentation, including examples, is available on the [noUiSlider docume

Changes
-------
**Changelog for version 4:**

**Changelog for version 4.2:**
_[current patch release]_
+ Fixed some minor CSS issues in the default theme
+ The slider will no longer force an arbitrary width or height
+ Changed source to comply to more JsLint suggestions
+ Removed compressed versions from the tracking system. They'll still be produced and provided, but they'll only be bundled in the [Github Releases Feature](https://github.com/blog/1547-release-your-software).
+ Some very small changes to internal input testing

**Changelog for version 4:**
_[current major release]_

* Massive update overhauling the entire code style
* Better styling possibilties
* Brand new Flat theme
* Windows Phone 8 support
* Performance improvements
* New way of handling disabled sliders
* Internal option testing provides feedback on issues
+ Massive update overhauling the entire code style
+ Better styling possibilities
+ Brand new Flat theme
+ Windows Phone 8 support
+ Performance improvements
+ New way of handling disabled sliders
+ Internal option testing provides feedback on issues

Version numbering
------------------------------
Version numbering follows the 'Semantic versioning' style.
You'll find an excellent documentation at [Semver.org](http://semver.org/).

Compression and Error checking
------------------------------
**CSS** ([CSSMinifier](http://cssminifier.com/))
The stylesheet is trimmed of whitespace and comments to provide a `min` version.

**CSS**
The stylesheet is compressed using:
[CSSMinifier](http://cssminifier.com/)
**JS** ([Google Closure Compiler](http://closure-compiler.appspot.com/home))
The plugin is compressed using the Google Closure compiler, using the 'simple' optimization option.

**JS**
The plugin is compressed using the Google Closure compiler, using the 'simple' optimalization option.
[Google Closure Compiler](http://closure-compiler.appspot.com/home)

**Code**
**Code** ([JsLint](http://jslint.com/))
The plugin code is checked using JsLint, with the following options:
`/*jslint browser: true, devel: true, nomen: true, plusplus: true, unparam: true, sloppy: true, todo: true, white: true */`
```
browser: true
devel: true
plusplus: true
unparam: true
sloppy: true
white: true
```

Please note that while some errors remain without these options, they are merely differences in coding style. Using `++` for example, is in my opinion very clear in a `for` loop. Some jQuery methods offer callbacks noUiSlider doesn't require, thus requiring `unparam`, and the `devel` option is required for the `console` statements. The `sloppy` option refers to a missing `"use strict"` statement, which isn't included for lack of testing.

Known issues
------------
There are some minor issues remaining in noUiSlider 4. It is a priority to fix these issues.

Please note that while some errors remain, these are not issues as they are merely a difference in coding style.
[JsLint](http://jslint.com/)
+ Firefox will prefer scrolling to dragging the slider on touch events. The `preventDefault()` call that prevents this in other browser seems to fail here.
+ In IE10, tapping the slider to move it will fail in with these conditions:
+ The paged is zoomed;
+ The slider uses the `orientation: vertical` option
+ The page is scrolled, so that `scrollTop` > 0
This issue affects both IE10 in Windows 8 and Windows Phone 8.
27 changes: 17 additions & 10 deletions jquery.nouislider.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

/* General CSS resets;
* The target itself is not affected, allowing
* the remainder of the document to use an
* the remainder of the document to use an
* alternate box-sizing model;
* Support for box-sizing is wide spread:
* http://caniuse.com/#search=box-sizing
Expand All @@ -19,17 +19,21 @@
}

/* Main slider bar;
* Standard styles no longer incorrectly force a
* width or height on the slider.
*/
.noUi-base {
height: 40px;
width: 300px;
position: relative;
max-width: 100%;
max-height: 100%;
border: 1px solid #bfbfbf;
z-index: 1;
}

/* Handles + active state;
* The :after pseudo-element wont inherit
* box-sizing, so it needs to applied manually.
*/
.noUi-handle {
background: #EEE;
Expand All @@ -42,6 +46,9 @@
background: #E9E9E9;
}
.noUi-active:after {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
content: "";
display: block;
height: 100%;
Expand Down Expand Up @@ -76,13 +83,13 @@
.noUi-z-index {
z-index: 10;
}

/* Adaptations for the vertical slider;
* Some standard styles have been extended to keep
* exceptions for the vertical slider as minimal as possible.
*/
.noUi-vertical {
height: 300px;
width: 40px;
max-height: 100%;
}
.noUi-vertical .noUi-origin {
bottom: 0;
Expand All @@ -93,11 +100,11 @@
}

/* Various alternate slider states;
* Support for transition is widely available,
* Only IE7, IE8 and IE9 will ignore these rules.
* Since this is merely a progressive enhancement,
* this is no problem at all.
* http://caniuse.com/#search=transition
* Support for transition is widely available,
* Only IE7, IE8 and IE9 will ignore these rules.
* Since this is merely a progressive enhancement,
* this is no problem at all.
* http://caniuse.com/#search=transition
*/
.noUi-target[disabled] .noUi-base {
background: #999;
Expand Down
Loading

0 comments on commit 3d28bcf

Please sign in to comment.