noUiSlider 13.1.0

leongersen · Feb 8, 2019 · f219423 · f219423
1 parent ce20522
commit f219423
Show file tree

Hide file tree

Showing 6 changed files with 50 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ An extensive documentation, including **examples**, **options** and **configurat
 Changelog
 ---------
 
-### 13.1.0 (*???*)
+### 13.1.0 (*2018-02-08*)
 - Fixed: Updating `pips` using `updateOptions` (#933);
 - Added: Updating `tooltips` using `updateOptions` (#946);
 

diff --git a/distribute/nouislider.css b/distribute/nouislider.css
@@ -1,4 +1,4 @@
-/*! nouislider - 13.0.0 - 2/6/2019 */
+/*! nouislider - 13.1.0 - 2/8/2019 */
 /* Functional styling;
  * These styles are required for noUiSlider to function.
  * You don't need to change these rules to apply your design.

diff --git a/distribute/nouislider.js b/distribute/nouislider.js
@@ -1,4 +1,4 @@
-/*! nouislider - 13.0.0 - 2/6/2019 */
+/*! nouislider - 13.1.0 - 2/8/2019 */
 (function(factory) {
     if (typeof define === "function" && define.amd) {
         // AMD. Register as an anonymous module.
@@ -13,7 +13,7 @@
 })(function() {
     "use strict";
 
-    var VERSION = "13.0.0";
+    var VERSION = "13.1.0";
 
     function isValidFormatter(entry) {
         return typeof entry === "object" && typeof entry.to === "function" && typeof entry.from === "function";
@@ -958,6 +958,7 @@
         var scope_Handles;
         var scope_Connects;
         var scope_Pips;
+        var scope_Tooltips;
 
         // Override for the 'animate' option
         var scope_ShouldAnimate = true;
@@ -1094,13 +1095,27 @@
             return handleOrigin.hasAttribute("disabled");
         }
 
+        function removeTooltips() {
+            if (scope_Tooltips) {
+                removeEvent("update.tooltips");
+                scope_Tooltips.forEach(function(tooltip) {
+                    if (tooltip) {
+                        removeElement(tooltip);
+                    }
+                });
+                scope_Tooltips = null;
+            }
+        }
+
         // The tooltips option is a shorthand for using the 'update' event.
         function tooltips() {
+            removeTooltips();
+
             // Tooltips are added with options.tooltips in original order.
-            var tips = scope_Handles.map(addTooltip);
+            scope_Tooltips = scope_Handles.map(addTooltip);
 
-            bindEvent("update", function(values, handleNumber, unencoded) {
-                if (!tips[handleNumber]) {
+            bindEvent("update.tooltips", function(values, handleNumber, unencoded) {
+                if (!scope_Tooltips[handleNumber]) {
                     return;
                 }
 
@@ -1110,7 +1125,7 @@
                     formattedValue = options.tooltips[handleNumber].to(unencoded[handleNumber]);
                 }
 
-                tips[handleNumber].innerHTML = formattedValue;
+                scope_Tooltips[handleNumber].innerHTML = formattedValue;
             });
         }
 
@@ -2284,10 +2299,22 @@
             // If 'snap' and 'step' are not passed, they should remain unchanged.
             var v = valueGet();
 
-            var updateAble = ["margin", "limit", "padding", "range", "animate", "snap", "step", "format"];
+            var updateAble = [
+                "margin",
+                "limit",
+                "padding",
+                "range",
+                "animate",
+                "snap",
+                "step",
+                "format",
+                "pips",
+                "tooltips"
+            ];
 
             // Only change options that we're actually passed to update.
             updateAble.forEach(function(name) {
+                // Check for undefined. null removes the value.
                 if (optionsToUpdate[name] !== undefined) {
                     originalOptions[name] = optionsToUpdate[name];
                 }
@@ -2312,6 +2339,15 @@
             // Update pips, removes existing.
             if (options.pips) {
                 pips(options.pips);
+            } else {
+                removePips();
+            }
+
+            // Update tooltips, removes existing.
+            if (options.tooltips) {
+                tooltips();
+            } else {
+                removeTooltips();
             }
 
             // Invalidate the current positioning so valueSet forces an update.
@@ -2364,6 +2400,7 @@
             updateOptions: updateOptions,
             target: scope_Target, // Issue #597
             removePips: removePips,
+            removeTooltips: removeTooltips,
             pips: pips // Issue #594
         };
 

diff --git a/distribute/nouislider.min.css b/distribute/nouislider.min.css
diff --git a/distribute/nouislider.min.js b/distribute/nouislider.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nouislider",
-  "version": "13.0.0",
+  "version": "13.1.0",
   "main": "distribute/nouislider.js",
   "style": "distribute/nouislider.min.css",
   "license": "MIT",