OAuth2Client: use correct auth method for token introspection #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When token introspection was introduced in 6f5d19a, using the code that previously only handled token revocation, the new `_handle_token_hint` method that does the work for both `introspect_token` and `revoke_token` kept using `self.revocation_endpoint_auth_method` unconditionally if no `auth` was passed in with the introspect or revoke request. This seems to be wrong, introspecting a token should use the `token_endpoint_auth_method`. This leaves the fallback to `revocation_endpoint_auth_method` in `_handle_token_hint` because adjusting its signature to make `auth` compulsory would be awkward, but it's not expected ever to be used. Signed-off-by: Adam Williamson <[email protected]>
|
As I work for Red Hat I cannot agree to "consent that the copyright of your pull request source code belongs to Authlib's author" without my employer's permission, but I think this change is too trivial to be copyrightable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When token introspection was introduced in 6f5d19a, using the code that previously only handled token revocation, the new
_handle_token_hintmethod that does the work for bothintrospect_tokenandrevoke_tokenkept usingself.revocation_endpoint_auth_methodunconditionally if noauthwas passed in with the introspect or revoke request. This seems to be wrong, introspecting a token should use thetoken_endpoint_auth_method.This leaves the fallback to
revocation_endpoint_auth_methodin_handle_token_hintbecause adjusting its signature to makeauthcompulsory would be awkward, but it's not expected ever to be used.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)