Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Пауза при получении ошибки #127

Merged
merged 2 commits into from
Jan 10, 2021

Conversation

leshchenko1979
Copy link
Owner

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 10, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.40%.

Quality metrics Before After Change
Complexity 2.16 ⭐ 2.18 ⭐ 0.02 👎
Method Length 33.21 ⭐ 35.02 ⭐ 1.81 👎
Working memory 6.18 ⭐ 6.13 ⭐ -0.05 👍
Quality 83.64% 83.24% -0.40% 👎
Other metrics Before After Change
Lines 587 613 26
Changed files Quality Before Quality After Quality Change
fast_bitrix24/bitrix.py 82.78% ⭐ 81.82% ⭐ -0.96% 👎
fast_bitrix24/mult_request.py 81.22% ⭐ 80.88% ⭐ -0.34% 👎
fast_bitrix24/srh.py 85.14% ⭐ 84.94% ⭐ -0.20% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
fast_bitrix24/mult_request.py MultipleServerRequestHandler.generate_a_task 1 ⭐ 54 ⭐ 16 ⛔ 65.85% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@leshchenko1979 leshchenko1979 changed the title bugfix Пауза при получении ошибки Jan 10, 2021
@leshchenko1979 leshchenko1979 merged commit 7782a11 into master Jan 10, 2021
@leshchenko1979 leshchenko1979 deleted the leshchenko1979/issue126 branch January 10, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant