Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Параметры ограничения скорости запросов в конструкторе #219

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

leshchenko1979
Copy link
Owner

Fixes #218

Теперь в конструкторе можно изменить параметры скорости запросов -- размер пула и количество запросов в секунду

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey leshchenko1979 - Here's my review!

General suggestions:

  • Consider adding more detailed documentation or examples on how users can determine the optimal request pool size and requests per second for their specific use case.
  • It might be beneficial to include guidance or warnings about the consequences of setting these parameters too high, such as potential rate limiting by Bitrix24.
  • Explore the possibility of implementing a fallback or recovery mechanism for when the specified rate limits are exceeded, to enhance the robustness of the client.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tests/test_server_responses.py Show resolved Hide resolved
tests/test_srh.py Show resolved Hide resolved
fast_bitrix24/srh.py Show resolved Hide resolved
fast_bitrix24/bitrix.py Show resolved Hide resolved
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (1d6ab40) to head (4871eb3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   88.59%   88.55%   -0.05%     
==========================================
  Files          11       11              
  Lines         561      559       -2     
==========================================
- Hits          497      495       -2     
  Misses         64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leshchenko1979 leshchenko1979 merged commit c4b3cc8 into master Mar 5, 2024
11 checks passed
@leshchenko1979 leshchenko1979 deleted the leshchenko1979/issue218 branch March 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Параметры ограничения скорости запросов в конструкторе
1 participant